From c82c747a7fb8e0081f9185e199ce1611fe5d073a Mon Sep 17 00:00:00 2001 From: MarcosPividori Date: Tue, 24 May 2016 11:37:10 -0300 Subject: [PATCH] Properly use Enum type. --- src/mlpack/methods/range_search/range_search_main.cpp | 2 +- src/mlpack/methods/range_search/rs_model.cpp | 2 +- src/mlpack/methods/range_search/rs_model.hpp | 8 ++++---- src/mlpack/methods/rann/allkrann_main.cpp | 2 +- src/mlpack/methods/rann/ra_model.hpp | 8 ++++---- src/mlpack/methods/rann/ra_model_impl.hpp | 6 +++--- 6 files changed, 14 insertions(+), 14 deletions(-) diff --git a/src/mlpack/methods/range_search/range_search_main.cpp b/src/mlpack/methods/range_search/range_search_main.cpp index 48fd2ede30a..3606950e2f6 100644 --- a/src/mlpack/methods/range_search/range_search_main.cpp +++ b/src/mlpack/methods/range_search/range_search_main.cpp @@ -160,7 +160,7 @@ int main(int argc, char *argv[]) const string treeType = CLI::GetParam("tree_type"); const bool randomBasis = CLI::HasParam("random_basis"); - int tree = 0; + RSModel::TreeTypes tree = RSModel::KD_TREE; if (treeType == "kd") tree = RSModel::KD_TREE; else if (treeType == "cover") diff --git a/src/mlpack/methods/range_search/rs_model.cpp b/src/mlpack/methods/range_search/rs_model.cpp index 7ffc97d41ed..e0cdb18da0a 100644 --- a/src/mlpack/methods/range_search/rs_model.cpp +++ b/src/mlpack/methods/range_search/rs_model.cpp @@ -14,7 +14,7 @@ using namespace mlpack::range; * Initialize the RSModel with the given tree type and whether or not a random * basis should be used. */ -RSModel::RSModel(int treeType, bool randomBasis) : +RSModel::RSModel(TreeTypes treeType, bool randomBasis) : treeType(treeType), randomBasis(randomBasis), kdTreeRS(NULL), diff --git a/src/mlpack/methods/range_search/rs_model.hpp b/src/mlpack/methods/range_search/rs_model.hpp index a3827b529a1..9598981ff46 100644 --- a/src/mlpack/methods/range_search/rs_model.hpp +++ b/src/mlpack/methods/range_search/rs_model.hpp @@ -33,7 +33,7 @@ class RSModel }; private: - int treeType; + TreeTypes treeType; size_t leafSize; //! If true, we randomly project the data into a new basis before search. @@ -69,7 +69,7 @@ class RSModel * @param treeType Type of tree to use. * @param randomBasis Whether or not to use a random basis. */ - RSModel(const int treeType = TreeTypes::KD_TREE, + RSModel(const TreeTypes treeType = TreeTypes::KD_TREE, const bool randomBasis = false); /** @@ -100,9 +100,9 @@ class RSModel size_t& LeafSize() { return leafSize; } //! Get the type of tree. - int TreeType() const { return treeType; } + TreeTypes TreeType() const { return treeType; } //! Modify the type of tree (don't do this after the model has been built). - int& TreeType() { return treeType; } + TreeTypes& TreeType() { return treeType; } //! Get whether a random basis is used. bool RandomBasis() const { return randomBasis; } diff --git a/src/mlpack/methods/rann/allkrann_main.cpp b/src/mlpack/methods/rann/allkrann_main.cpp index 6efb097fd4a..ce6f9f1bdcd 100644 --- a/src/mlpack/methods/rann/allkrann_main.cpp +++ b/src/mlpack/methods/rann/allkrann_main.cpp @@ -161,7 +161,7 @@ int main(int argc, char *argv[]) const string treeType = CLI::GetParam("tree_type"); const bool randomBasis = CLI::HasParam("random_basis"); - int tree = 0; + RANNModel::TreeTypes tree = RANNModel::KD_TREE; if (treeType == "kd") tree = RANNModel::KD_TREE; else if (treeType == "cover") diff --git a/src/mlpack/methods/rann/ra_model.hpp b/src/mlpack/methods/rann/ra_model.hpp index fffdb5825b6..a04107fce70 100644 --- a/src/mlpack/methods/rann/ra_model.hpp +++ b/src/mlpack/methods/rann/ra_model.hpp @@ -45,7 +45,7 @@ class RAModel private: //! The type of tree being used. - int treeType; + TreeTypes treeType; //! The leaf size of the tree being used (useful only for the kd-tree). size_t leafSize; @@ -79,7 +79,7 @@ class RAModel * Initialize the RAModel with the given type and whether or not a random * basis should be used. */ - RAModel(int treeType = TreeTypes::KD_TREE, bool randomBasis = false); + RAModel(TreeTypes treeType = TreeTypes::KD_TREE, bool randomBasis = false); //! Clean memory, if necessary. ~RAModel(); @@ -132,9 +132,9 @@ class RAModel size_t& LeafSize(); //! Get the type of tree being used. - int TreeType() const; + TreeTypes TreeType() const; //! Modify the type of tree being used. - int& TreeType(); + TreeTypes& TreeType(); //! Get whether or not a random basis is being used. bool RandomBasis() const; diff --git a/src/mlpack/methods/rann/ra_model_impl.hpp b/src/mlpack/methods/rann/ra_model_impl.hpp index 72f083bb72e..48b4b4aa33b 100644 --- a/src/mlpack/methods/rann/ra_model_impl.hpp +++ b/src/mlpack/methods/rann/ra_model_impl.hpp @@ -14,7 +14,7 @@ namespace mlpack { namespace neighbor { template -RAModel::RAModel(const int treeType, const bool randomBasis) : +RAModel::RAModel(const TreeTypes treeType, const bool randomBasis) : treeType(treeType), leafSize(20), randomBasis(randomBasis), @@ -377,13 +377,13 @@ size_t& RAModel::LeafSize() } template -int RAModel::TreeType() const +typename RAModel::TreeTypes RAModel::TreeType() const { return treeType; } template -int& RAModel::TreeType() +typename RAModel::TreeTypes& RAModel::TreeType() { return treeType; }