GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
I replaced SortStruct by std::pair in the R* tree and the X tree and fixed some compiler warnings about uninitialized variables. I did some tests, std::pair provides some speedups in mlpack_knn for the R* tree and the X tree.
Replace SortStruct by std::pair
Fix compiler warnings
I looked through the armadillo code, op_min::direct_min equates index_of_min_val to zero by default.
Yeah; I agree that the -Wuninitialized is erroneous in this case, but I am not sure there is any other way to stop that warning from appearing here other than initializing the index to 0. Do you know any other ways?
No, I don't. I think this is the easiest way.
Replace lambdas by a comparator.
Looks good to me. This fixes #721.
Do you mean #712? :)
Yep, I must have mistyped... :)
I mean to say that if the code looks good, did you forget to merge the PR?
Oh, yes, so I not only mistyped, I also hit the wrong button!