New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix TreeTrait for BallTree. #727

Merged
merged 1 commit into from Jul 19, 2016

Conversation

Projects
None yet
2 participants
@MarcosPividori
Contributor

MarcosPividori commented Jul 19, 2016

I update TreeTraits for Ball Trees, to set HasOverlappingChildren = true.
It shouldn't make any difference in current implementation because HasOverlappingChildren is not used in any method.
I thought it could be useful in the future. :)

@rcurtin

This comment has been minimized.

Show comment
Hide comment
@rcurtin

rcurtin Jul 19, 2016

Member

I agree, thanks for the fix.

Member

rcurtin commented Jul 19, 2016

I agree, thanks for the fix.

@rcurtin rcurtin merged commit f21439c into mlpack:master Jul 19, 2016

0 of 2 checks passed

continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment