switch last (!) remaining std::cout to destination #814

merged 1 commit into from Nov 20, 2016


None yet

2 participants

eddelbuettel commented Nov 20, 2016 edited

so I looked into why R was complaining that std::cout was referenced when linking against mlpack -- and it turns out that the (sole !!) remaining use of std::cout appears to be an instance that ought to have been converted to destination

this PR does that

no Travis build on my side; I just used to have a clone rather than fork and did not have Travis set up to build when I just committed this but it should work out just fine

@eddelbuettel eddelbuettel switch last (!) remaining std::cout to destination
rcurtin commented Nov 20, 2016

I agree, this is an error, thanks for the patch. :)

@rcurtin rcurtin merged commit d7a97df into mlpack:master Nov 20, 2016

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
continuous-integration/travis-ci/pr The Travis CI build passed
@eddelbuettel eddelbuettel deleted the eddelbuettel:bugfix/last_stdcout_to_destination branch Nov 20, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment