New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

switch last (!) remaining std::cout to destination #814

Merged
merged 1 commit into from Nov 20, 2016

Conversation

Projects
None yet
2 participants
@eddelbuettel
Copy link
Contributor

eddelbuettel commented Nov 20, 2016

so I looked into why R was complaining that std::cout was referenced when linking against mlpack -- and it turns out that the (sole !!) remaining use of std::cout appears to be an instance that ought to have been converted to destination

this PR does that

no Travis build on my side; I just used to have a clone rather than fork and did not have Travis set up to build when I just committed this but it should work out just fine

@rcurtin

This comment has been minimized.

Copy link
Member

rcurtin commented Nov 20, 2016

I agree, this is an error, thanks for the patch. :)

@rcurtin rcurtin merged commit d7a97df into mlpack:master Nov 20, 2016

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@eddelbuettel eddelbuettel deleted the eddelbuettel:bugfix/last_stdcout_to_destination branch Nov 20, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment