Update knn_main.cpp #816

Merged
merged 1 commit into from Nov 23, 2016

Conversation

Projects
None yet
2 participants
@goalslee
Contributor

goalslee commented Nov 23, 2016

the type of "query" is arma::mat not string! it cause the runtime error

Update knn_main.cpp
the type of "query" is arma::mat not string!
@rcurtin

This comment has been minimized.

Show comment
Hide comment
@rcurtin

rcurtin Nov 23, 2016

Member

Hi there,

Thank you very much for pointing this out! I will release mlpack 2.1.1 as a bugfix immediately.
If you would like, I can add your name to the list of contributors. Let me know.

Thanks,

Ryan

Member

rcurtin commented Nov 23, 2016

Hi there,

Thank you very much for pointing this out! I will release mlpack 2.1.1 as a bugfix immediately.
If you would like, I can add your name to the list of contributors. Let me know.

Thanks,

Ryan

@rcurtin rcurtin merged commit 7d7b1ff into mlpack:master Nov 23, 2016

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@rcurtin

This comment has been minimized.

Show comment
Hide comment
@rcurtin

rcurtin Nov 23, 2016

Member

Oops, sorry, I misspoke---I thought this was a bug in mlpack 2.1.0 but this code is only in master, not in 2.1.0, so there is no need for a sudden release.

Member

rcurtin commented Nov 23, 2016

Oops, sorry, I misspoke---I thought this was a bug in mlpack 2.1.0 but this code is only in master, not in 2.1.0, so there is no need for a sudden release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment