New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug of variadic template parameters of Optimizer #967

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
3 participants
@ShangtongZhang
Member

ShangtongZhang commented Mar 28, 2017

I just found I can't use cherry pick... So I create a separate PR for this fix.

@mlpack-jenkins

This comment has been minimized.

Show comment
Hide comment
@mlpack-jenkins

mlpack-jenkins Mar 28, 2017

Can one of the admins verify this patch?

mlpack-jenkins commented Mar 28, 2017

Can one of the admins verify this patch?

@zoq

This comment has been minimized.

Show comment
Hide comment
@zoq

zoq Mar 28, 2017

Member

I forgot to push the changes; there where a couple of other places that I updated too. Also when using variadict templates we use the convention:

template<typename... Arguments> class classname;

And if the type isn't used like in this case:

template<
    template<typename> class OptimizerType = mlpack::optimization::RMSprop
    template<typename...> class OptimizerType = mlpack::optimization::RMSprop
>
void Train(const arma::mat& predictors, const arma::mat& responses);

we don't have to provide the OptimizerTypeArgs args. For more information take a look at: 2344eba

Member

zoq commented Mar 28, 2017

I forgot to push the changes; there where a couple of other places that I updated too. Also when using variadict templates we use the convention:

template<typename... Arguments> class classname;

And if the type isn't used like in this case:

template<
    template<typename> class OptimizerType = mlpack::optimization::RMSprop
    template<typename...> class OptimizerType = mlpack::optimization::RMSprop
>
void Train(const arma::mat& predictors, const arma::mat& responses);

we don't have to provide the OptimizerTypeArgs args. For more information take a look at: 2344eba

@zoq zoq closed this Mar 28, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment