New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor FFN #995

Merged
merged 7 commits into from May 16, 2017

Conversation

Projects
None yet
4 participants
@ShangtongZhang
Member

ShangtongZhang commented May 9, 2017

  • Support copy/assignment CTOR

  • Add a new function SetTrainingData for async rl methods
    This is mainly for compute gradients

    learningNetwork.SetTrainingData(state, target);
    arma::mat gradients;
    learningNetwork.Gradient(learningNetwork.Parameters(), 0, gradients);
  • Expose a private function ResetParameters to public
@mlpack-jenkins

This comment has been minimized.

Show comment
Hide comment
@mlpack-jenkins

mlpack-jenkins May 9, 2017

Can one of the admins verify this patch?

mlpack-jenkins commented May 9, 2017

Can one of the admins verify this patch?

@@ -76,10 +76,10 @@ class GaussianInitialization
private:
//! Mean of the gaussian.
const double mean;
double mean;

This comment has been minimized.

@ShangtongZhang

ShangtongZhang May 9, 2017

Member

class with const member variable doesn't support assignment operator, so I just removed the const qualifier.

@ShangtongZhang

ShangtongZhang May 9, 2017

Member

class with const member variable doesn't support assignment operator, so I just removed the const qualifier.

@ShangtongZhang

This comment has been minimized.

Show comment
Hide comment
@ShangtongZhang

ShangtongZhang May 12, 2017

Member

Hope it's ready to merge now

Member

ShangtongZhang commented May 12, 2017

Hope it's ready to merge now

ShangtongZhang added some commits May 12, 2017

@zoq

zoq approved these changes May 13, 2017

Besides the really minor issues, this is ready to be merged.

Show outdated Hide outdated src/mlpack/methods/ann/ffn.hpp
Show outdated Hide outdated src/mlpack/methods/ann/ffn.hpp

@zoq zoq merged commit 3efd8d9 into mlpack:master May 16, 2017

3 checks passed

Style Checks Build finished.
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@zoq

This comment has been minimized.

Show comment
Hide comment
@zoq

zoq May 16, 2017

Member

Thanks for the great work!

Member

zoq commented May 16, 2017

Thanks for the great work!

@ShangtongZhang ShangtongZhang deleted the ShangtongZhang:rl-ffn branch May 16, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment