don't add additional classes if FailureModel encountered #1984
However, I tried to write a test to replicate the behaviour of #1981 using the mock learners, but I have to admit, that I'm not able to do that. Unfortunately, I don't have the time at the moment to dive deeper in the
Try to keep the unit test as small as possible, i.e., reduce your initial code from the bug report as much as possible. And use a mock learner to trigger a
When you have an initial version for the unittest we can review.
EDIT: I think your rebase didn't quite work, there are a lot of changes that are not relevant for your PR
Since you're working in a seperate fork I can't directly do the rebase for you.
The steps should look like that:
This should solve the problem
2 times, most recently
Mar 3, 2018
@dagola Could you check the checkbox "allow edits from maintainers"? So we can finish this PR here. Otherwise I would manually need to copy all of your changes to make additional ones.
The Travis error is probably caused because variable