Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Featuer: add `getLearnerNote()` to access Notes information of learners #2086

Merged
merged 1 commit into from Jun 9, 2019

Conversation

Projects
None yet
4 participants
@alona-sydorova
Copy link
Contributor

commented Dec 5, 2017

fixes #1463

@jakob-r

This comment has been minimized.

Copy link
Member

commented Dec 5, 2017

This will not work for wrapped learners, should we S3 that?

@larskotthoff

This comment has been minimized.

Copy link
Contributor

commented Dec 7, 2017

Yes. (And please don't regenerate/commit Rd files.)

@larskotthoff

This comment has been minimized.

Copy link
Contributor

commented Dec 13, 2017

@berndbischl berndbischl force-pushed the mlr-org:master branch 2 times, most recently from cf3db65 to 57f099e Mar 3, 2018

@ja-thomas ja-thomas force-pushed the mlr-org:master branch from 57f099e to 20d5a39 Mar 3, 2018

@pat-s

This comment has been minimized.

Copy link
Member

commented Jun 6, 2019

This will not work for wrapped learners, should we S3 that?

Is this really important here? The other operators also do not work in an S3 way.
It's a really small change and just completes the getLearner*() family.

I cannot clean up here since its a fork. Should we just add this change in a single commit? @jakob-r @larskotthoff

@larskotthoff

This comment has been minimized.

Copy link
Contributor

commented Jun 6, 2019

Sounds good to me.

@jakob-r

This comment has been minimized.

Copy link
Member

commented Jun 6, 2019

If you want to, you can merge.

@pat-s pat-s changed the title added getLearnerNote() for learners Featuer: add `getLearnerNote()` to access Notes information of learners Jun 9, 2019

@pat-s pat-s merged commit 303c2e1 into mlr-org:master Jun 9, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

pat-s added a commit that referenced this pull request Jun 9, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.