Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature importance for h2o learners #2434

Merged

Conversation

3 participants
@markusdumke
Copy link
Contributor

commented Sep 21, 2018

Relates to #2433

markusdumke added some commits Sep 21, 2018

@larskotthoff

This comment has been minimized.

Copy link
Contributor

commented Sep 22, 2018

Thanks, looks good! Could you add a test for this please?

markusdumke and others added some commits Oct 4, 2018

@pat-s

This comment has been minimized.

Copy link
Member

commented Apr 11, 2019

@markusdumke Could you add a test please? Then we can merge this. Or at least allow edits from maintainers so we have a chance to do so :)

@markusdumke

This comment has been minimized.

Copy link
Contributor Author

commented Apr 14, 2019

@pat-s I have added a test, so I think it can be merged now.

@larskotthoff

This comment has been minimized.

Copy link
Contributor

commented Apr 15, 2019

Thanks, looks good -- merging.

@larskotthoff larskotthoff merged commit f74a639 into mlr-org:master Apr 15, 2019

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
deploy/netlify Deploy preview ready!
Details

larskotthoff added a commit that referenced this pull request Apr 15, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.