Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
Filter: Improve method of loading required filter pkgs #2483
referenced this pull request
Nov 13, 2018
Idk, just "searched in files" the whole repo but couldn't find any instances.
Ok, so we should use
The real problem is the
allpkg = unlist(extractSubList(filter, "pkg")) requirePackages(allpkg, why = "generateFilterValuesData", default.method = "load")
(sorry am on mobile rn so can't test. maybe one needs an
Packages are still a chr vec. The only thing that changed is that filters that require NO pkg to be loaded (i.e. these pkgs are in base-R and loaded by default) now do not have a slot
That's why I changed the assert function to accept
The param decription of
i still dont get why we do that? as this is not consistent with what we do in learners?