Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expanded functionality for regr.h2o.gbm #2508

Merged
merged 17 commits into from Feb 25, 2019

Conversation

3 participants
@j-hartshorn
Copy link
Contributor

j-hartshorn commented Dec 17, 2018

This pull request implements the suggestions in #2208 for regr.h2o.gbm and elaborates on the available parameters.

In particular, it removes the decision to hard code distribution = "gaussian" from the learner and allows the use of others.

@larskotthoff

This comment has been minimized.

Copy link
Contributor

larskotthoff commented Dec 18, 2018

Thanks, looks good. Could you add a few of those new parameters in the test please so that they're checked automatically?

joe-hartshorn and others added some commits Feb 1, 2019

joe-hartshorn
@j-hartshorn

This comment has been minimized.

Copy link
Contributor Author

j-hartshorn commented Feb 1, 2019

Thanks, looks good. Could you add a few of those new parameters in the test please so that they're checked automatically?

Added!

I'm not sure what I can do about the appveyor build failing, any suggestions?

@pat-s

This comment has been minimized.

Copy link
Member

pat-s commented Feb 1, 2019

Appveyor build is not stable atm, merging a PR soon. Just ignore if for now.

pat-s and others added some commits Feb 3, 2019

j-hartshorn and others added some commits Feb 20, 2019

@pat-s

This comment has been minimized.

Copy link
Member

pat-s commented Feb 20, 2019

Will take a closer look in the next days, please ping if not ;)

@pat-s

pat-s approved these changes Feb 25, 2019

@pat-s pat-s merged commit f807f99 into mlr-org:master Feb 25, 2019

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
deploy/netlify Deploy preview ready!
Details

pat-s added a commit that referenced this pull request Feb 25, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.