Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added MiniBatchKmeans from ClusterR package to Learners #2554

Merged
merged 10 commits into from May 20, 2019

Conversation

Projects
None yet
3 participants
@Prasiddhi
Copy link
Contributor

commented Mar 11, 2019

Added MiniBatchKmeans from ClusterR package.

Prediction is via predict_MBatchKMeans of ClusterR package.

We are always happy to receive pull requests.

Please make sure you have read our coding guidelines:
https://github.com/mlr-org/mlr/wiki/mlr-Coding-Guidelines

This especially means that you have understood:

  • The style guide - our lintr will provide you feedback on this
  • How to run tests locally. Yes, travis will also run them for you, bad it is annoying to wait for this.
  • How to run R CMD CHECK locally. See point before.

Also it's helpful to get into direct contact with the suggested reviewers to get help, getting your PR merged.
You might want to join our slack at:
https://mlr-org.slack.com

Prasiddhi added some commits Mar 11, 2019

Merge pull request #1 from mlr-org/master
use geom_raster because its more performant (#2549)
Show resolved Hide resolved tests/testthat/test_cluster_MiniBatchKmeans.R Outdated
Show resolved Hide resolved tests/testthat/test_cluster_MiniBatchKmeans.R Outdated

Prasiddhi and others added some commits Mar 12, 2019

@pat-s

pat-s approved these changes May 14, 2019

@pat-s

This comment has been minimized.

Copy link
Member

commented May 14, 2019

@Prasiddhi
Thanks for contributing. Could you please add the package to DESCRIPTION and an entry to NEWS.md, following the structure you find in there?

pat-s added some commits May 18, 2019

@pat-s

This comment has been minimized.

Copy link
Member

commented May 19, 2019

@larskotthoff If you approve, please merge.

@larskotthoff

This comment has been minimized.

Copy link
Contributor

commented May 20, 2019

Thanks, merging.

@larskotthoff larskotthoff merged commit 9763ad1 into mlr-org:master May 20, 2019

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
deploy/netlify Deploy preview ready!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.