New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable parallel tests #278
Conversation
tests/testthat/helper.R
Outdated
@@ -6,15 +6,15 @@ expect_tuner = function(tuner) { | |||
public = c("optimize", "param_set"), | |||
private = ".optimize" | |||
) | |||
expect_is(tuner$param_set, "ParamSet") | |||
expect_s3_class(tuner$param_set, "ParamSet") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can't we leave it as it is? Because it is not really an S3 class - only technically.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The old form is deprecated and will error at some point.
expect_class
might also work.
tests/testthat/helper.R
Outdated
expect_function(tuner$optimize, args = "inst") | ||
} | ||
|
||
expect_terminator = function(term) { | ||
expect_r6(term, "Terminator", | ||
public = c("is_terminated", "param_set") | ||
) | ||
expect_is(term$param_set, "ParamSet") | ||
expect_s3_class(term$param_set, "ParamSet") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
see above
and require testthat v3.0