Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deep clone $values #273

Merged
merged 3 commits into from
Apr 13, 2020
Merged

deep clone $values #273

merged 3 commits into from
Apr 13, 2020

Conversation

mb706
Copy link
Contributor

@mb706 mb706 commented Apr 3, 2020

fixes #272

@mb706
Copy link
Contributor Author

mb706 commented Apr 3, 2020

Using the default clone method of R6 objects on the $values slot now

@codecov-io
Copy link

codecov-io commented Apr 12, 2020

Codecov Report

Merging #273 into master will increase coverage by 0.05%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #273      +/-   ##
==========================================
+ Coverage   95.16%   95.21%   +0.05%     
==========================================
  Files          20       20              
  Lines         496      502       +6     
==========================================
+ Hits          472      478       +6     
  Misses         24       24              
Impacted Files Coverage Δ
R/ParamSet.R 97.38% <100.00%> (+0.10%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 745d89b...885cc54. Read the comment docs.

@mllg mllg merged commit aedbbd1 into master Apr 13, 2020
@mllg mllg deleted the fix_272_clone branch April 13, 2020 22:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deep cloning values of a ParamSet within an R6 object
3 participants