Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove redundant nodes from the tree #559

Closed
bifurcation opened this issue Jan 27, 2022 · 2 comments
Closed

Remove redundant nodes from the tree #559

bifurcation opened this issue Jan 27, 2022 · 2 comments

Comments

@bifurcation
Copy link
Collaborator

@bifurcation bifurcation commented Jan 27, 2022

Right now, the UpdatePath generation and processing algorithms populate "redundant" parent nodes in the tree, in the sense that they have only one child node. These redundant nodes are harmless except that they make tree truncation less effective. We should update the UpdatePath algorithms so that they do not add redundant nodes to the tree.

@raphaelrobert
Copy link
Member

@raphaelrobert raphaelrobert commented Jan 31, 2022

I think the definition of redundant is slightly different than what you propose. Redundant nodes are nodes with a resolution of only one leaf node, where all parent nodes are filtered out of the resolution. I think in the very early days we called that a "shadow".

With the definition you propose, I think it would become impossible to do the first-ever full commit in an otherwise empty tree.

@bifurcation
Copy link
Collaborator Author

@bifurcation bifurcation commented Feb 18, 2022

Fixed by #587

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants