Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make credential succession checking the AS's job #576

Closed
kkohbrok opened this issue Feb 3, 2022 · 2 comments
Closed

Make credential succession checking the AS's job #576

kkohbrok opened this issue Feb 3, 2022 · 2 comments

Comments

@kkohbrok
Copy link
Contributor

@kkohbrok kkohbrok commented Feb 3, 2022

Right now it says in the Update proposal section: "Verify that the set of identities attested by the credential is acceptable to the application for the participant being updated."

Firstly, I think this is a matter of authentication and thus the AS' job and secondly, it's a validation step that should probably go into the KeyPackage Validation section.

@bifurcation
Copy link
Collaborator

@bifurcation bifurcation commented Feb 3, 2022

Discussion on virtual interim:

  • Depends on what the boundary of the AS is:
    • Checking credential is valid
    • Also checking (credential -> credential) transitions
  • Moving this check to KP validation section would make it clearer
  • @kkohbrok to make a PR

@bifurcation bifurcation changed the title Make credential succession checking the AS' job Make credential succession checking the AS's job Feb 7, 2022
@bifurcation
Copy link
Collaborator

@bifurcation bifurcation commented Feb 13, 2022

Fixed by #584

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants