Editorial: Unclear that Commits always include an Update/refreshes the CIK for the committer. #286
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
beurdouche
changed the title
|
You can now rebase this on master for clarity. |
bifurcation
approved these changes
Jan 29, 2020
draft-ietf-mls-protocol.md
Outdated
|
|
||
| * Generate a provisional GroupContext object by applying the proposals | ||
| referenced in the initial Commit object in the order provided, as described in | ||
| {{proposals}}. Add proposals are applied left to right: Each Add proposal is | ||
| applied at the leftmost unoccupied leaf, or appended to the right edge of the | ||
| tree if all leaves are occupied. | ||
| tree if all leaves are occupied. The committer's own Update is applied last. |
There was a problem hiding this comment.
It would be good to make clear that the Update in question is the committer_update. Also, could you please check to make sure that DirectPath no longer touches the leaf? Since we have split out Update and committer_update, DirectPath should start at the parent of the Committer.
bifurcation
added
today! (?)
raphaelrobert
reviewed
Feb 5, 2020
draft-ietf-mls-protocol.md
Outdated
| @@ -1914,18 +1897,31 @@ struct { | |||
| ProposalID updates<0..2^16-1>; | |||
| ProposalID removes<0..2^16-1>; | |||
| ProposalID adds<0..2^16-1>; | |||
| ProposalID ignored<0..2^16-1>; | |||
|
|
|||
| Update committer_update; | |||
There was a problem hiding this comment.
Since an Update only contains a CIK, we should use the CIK right away here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
No description provided.