Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review of section 7. #311

Merged
merged 2 commits into from Mar 5, 2020
Merged

Review of section 7. #311

merged 2 commits into from Mar 5, 2020

Conversation

Bren2010
Copy link
Collaborator

@Bren2010 Bren2010 commented Mar 3, 2020

No description provided.

Copy link
Collaborator

@bifurcation bifurcation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small change, otherwise LGTM.

sync and up to date. When a client proposes a change to the tree
(e.g., to add or remove a member), it transmits a handshake message
sync and up to date. When a client commits a change to the tree
(e.g., to add or remove a set of members), it transmits a handshake message
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is just an example, so it doesn't cost any generality just to say "a member". And I think it reads more clearly.

@bifurcation bifurcation merged commit f227d0c into mlswg:master Mar 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

3 participants