Make the build reproducible #824
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ddennedy
requested changes
Jan 25, 2020
|
@ddennedy The major disadvantage of using Would you thus be amenable to a patch that worked on MacOS (and BSD…) |
|
Yes please amend to support BSD date as well. |
Whilst working on the Reproducible Builds effort [0] we noticed that shotcut could not be built reproducibly. This is because it uses the current build date for the SHOTCUT_VERSION variable. A patch is attached that bases this value on SOURCE_DATE_EPOCH [1] instead. This was originally filed in Debian as #949817 [2]. [0] https://reproducible-builds.org/ [1] https://reproducible-builds.org/specs/source-date-epoch/ [2] https://bugs.debian.org/949817
lamby
force-pushed
the
949817-shotcut-please-make-the-build-reproducible
branch
from
f2a0f32
to
e1c2ca5
Compare
|
@ddennedy Updated. :) |
ddennedy
approved these changes
Jan 27, 2020
tasmo
pushed a commit
to prototypefund/reproducible-website
that referenced
this pull request
Apr 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Whilst working on the Reproducible Builds effort we noticed that
shotcutcould not be built reproducibly.This is because it uses the current build date for the
SHOTCUT_VERSIONvariable. This PR bases this value onSOURCE_DATE_EPOCHinstead if available.This was originally filed in Debian as #949817.