Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Why type_name() is private? #58

Closed
zrkn opened this issue Dec 8, 2017 · 2 comments
Closed

Why type_name() is private? #58

zrkn opened this issue Dec 8, 2017 · 2 comments

Comments

@zrkn
Copy link

zrkn commented Dec 8, 2017

Hi.

When implementing ToLua/FromLua for custom types it would've been handy to have access to type name for returning it in ConversionError. Maybe make it public? Or add utility method for creating ConversionErrors with apropriate to/from values?
@jonas-schievink
Copy link
Contributor

It shouldn't do any harm to make type_name public, but I also envision the sort of helper method you want as part of #60 (should that ever be implemented)

@jugglerchris
Copy link
Collaborator

Value::type_name() is now public.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jugglerchris @jonas-schievink @zrkn