be careful about truncated multi byte strings - #64
Closed
romainfrancois wants to merge 1 commit into
Closed
Conversation
Contributor
Author
|
With this, I can get the |
Contributor
Author
|
I would argue now this is a missed opportunity in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #63
There's probably a better way to handle this but the situation described in #63 is that
openai_stream_ide_delta()receives a byte stream that is truncated in the middle of a multi byte string, which is common when you use emojis, etc ...So what this does is store the raw bytes in
ch_env$stream$bytes, parse the whole thing, and holistically try tonchar()therawToChar()edstring until there is no error.