syntactic fixes #32
Merged
syntactic fixes #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
December 7, 2020 15:12
|
hey @dfalbel I think it's fixed now :-)) (((really tricky to check against Python, because one assumes that translation-related parameters should be left as is while position-related parameters should be modified ... but then, with different methods involved I wasn't sure if that'd work out ... but it looks like it did))) Anyways, added some tests that should check for the correct behavior... |
|
Thanks very much @skeydan ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
syntactically this runs fine but I'm not yet sure about the semantics of this transform ... please don't merge yet