Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

Only include environment in server name if set. #4

Closed
wants to merge 1 commit into from

1 participant

@MarkBennett

This prevents server names from ending with an underscore and blank
environment.

@MarkBennett MarkBennett Only include environment in server name if set.
This prevents server names from ending with an underscore and blank
environment.
ce0390b
@MarkBennett

Given our conversation this morning, does it make sense to allow pave to run without an environment? Should it default to dev instead? Alternatively, should it just error out if no env is set?

We should make this behaviour consistent between plow and pave.

I'm OK with closing this PR if it doesn't make sense.

@MarkBennett

This doesn't make sense anymore since we're always setting the environment. Closing.

@MarkBennett MarkBennett closed this
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Apr 8, 2013
  1. @MarkBennett

    Only include environment in server name if set.

    MarkBennett authored
    This prevents server names from ending with an underscore and blank
    environment.
This page is out of date. Refresh to see the latest.
Showing with 3 additions and 1 deletion.
  1. +3 −1 bin/pave
View
4 bin/pave
@@ -70,7 +70,9 @@ if [ $LAUNCH ]; then
if [ ! $TAG ]; then
TAG=${PWD##*/}
[[ $ROLE ]] && TAG+="_$ROLE"
- TAG+="_$ENVIRONMENT"
+ if [ $ENVIRONMENT ]; then
+ TAG+="_$ENVIRONMENT"
+ fi
fi
EC2_RUN_RESULT=$(ec2-run-instances --instance-type $INSTANCE_TYPE --group default --region $REGION --key $KEYPAIR $AMI)
Something went wrong with that request. Please try again.