Add line clearing #7

Closed
wants to merge 3 commits into
from

2 participants

@henrikhodne

This is WIP, since there's a bug that causes the code to split newlines into
different result objects. The tests fail, so you can see the bugs in the test
result.

Any suggestions on how to fix the bug?

@henrikhodne henrikhodne Add line clearing
This is WIP, since there's a bug that causes the code to split
newlines into different result objects. The tests fail, so you can
see the bugs in the test result.
4633903
@henrikhodne

Figured out the error, pushing now code in a bit.

henrikhodne added some commits Dec 6, 2012
@henrikhodne henrikhodne Fix bug with line clearing
Whenever a control sequence is reached, a new result is created.
However, for line clearing, we don't necessarily want this, so let's
undo it.
5707b44
@henrikhodne henrikhodne Add ability to clear entire line 71a9712
@henrikhodne henrikhodne referenced this pull request Dec 6, 2012
Open

Erase line #4

@henrikhodne

So, while this works, the behaviour is actually not completely right. The cursor position shouldn't change when \e[K is used, but the script as it behaves now doesn't store the cursor position, so this would require a big change, and I don't know how to add that to the script.

@mmalecki mmalecki referenced this pull request in travis-ci/travis-ci May 9, 2013
Closed

Some weird ANSI codes could look better #386

@Mithgol

@mmalecki What would happen to logs on Travis (travis-ci/travis-ci#386) if this pull request is accepted “as is”?

@henrikhodne

@Mithgol Nothing, really, as I don't think we're using ansiparse anymore.

@henrikhodne henrikhodne deleted the henrikhodne:implement-line-clearing branch Feb 20, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment