Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

JS SDK initialization fix for IE #43

Merged
merged 5 commits into from Apr 27, 2011

Conversation

Projects
None yet
2 participants
Contributor

pomartel commented Apr 1, 2011

The JS SDK initialization does not work properly with IE. See this issue for details.

I made 3 changes to the way the JS SDK is initialized :

  1. Mimic the way the JS SDK is initialized in the Facebook documentation.
  2. Fixed bug with the channelUrl option. The option hash was defaulting keys to true and that caused a bug with the channelUrl when this property was intented to be nil.
  3. Added a locale option to change the language of the JS SDK.
Owner

mmangino commented Apr 1, 2011

There is a problem with this:

cookie = opts[:cookie] || true

You can never make it false. The old version used a default of true on nil to get around this case, but that fails with channel url. You might be able to do something similar, but please add test cases to catch this problem

Contributor

pomartel commented Apr 1, 2011

You're right! It's friday afternoon and I'm being sloppy trying to avoid testing! :-)

I think I fixed it and added a test file. There's just one test method at bottom I cannot get to work properly. It has to do with the way the result string is concatenated to the output buffer when a proc is passed. I tried to access the output buffer but I haven't had any luck.

Contributor

pomartel commented Apr 27, 2011

Hi Mike, did you have time to look at the updated pull request? Anything missing?

@mmangino mmangino added a commit that referenced this pull request Apr 27, 2011

@mmangino mmangino Merged pull request #43 from pomartel/js-sdk.
JS SDK initialization fix for IE
5969866

@mmangino mmangino merged commit 5969866 into mmangino:master Apr 27, 2011

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment