Here's a fix for the wrap-params issue #21

Closed
wants to merge 2 commits into
from

2 participants

@abedra

I played around with several variations of this, but in the end it seems best to just fall out to nil when it can't decode a parameter. I tried this by patching the jar in place on my project and things worked just fine.

@weavejester
Collaborator

Could you possibly write a quick test for this? I like to keep up to date with my regression tests.

@abedra
@abedra

ok i have checked in the exact test case that was previously failing for me.

@weavejester
Collaborator

I squashed your commits and merged them in. Thanks for the fix!

@abedra

Thanks! Any chance a release can be pushed?

@weavejester
Collaborator

I'll try and push out a release tonight. I have a few other fixes I was to make as well.

@abedra

Awesome! Let me know if I can help in any way

@weavejester
Collaborator

I've released 0.3.9 with this fix included.

@abedra

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment