/ring forked from ring-clojure/ring

0.2 Fixing an issue with response body as InputStream #6

Closed
wants to merge 1 commit into
from

Labels

None yet

Milestone

No milestone

Assignees

No one assigned

2 participants

@mtopolnik @weavejester
@mtopolnik
mtopolnik commented Nov 21, 2010

When the response body is an InputStream that gets copied to the response's OutputStream, if the OutputStream gets broken (e.g., the client interrupts the transfer), the InputStream will not get closed and the resources associated with it will not get released. Fixed by including the InputStream in with-open.

The same issue must be fixed on master.

@mtopolnik
mtopolnik commented Nov 23, 2010

Sorry, I see now that this request asks to pull the change into master, not the 0.2 branch. It should be pulled into 0.2, of course.

@weavejester
Collaborator
weavejester commented Apr 9, 2011

There doesn't seem to be any demand for updates to the 0.2 branch (and I'd rather everyone worked from 0.3.x anyway...). I'm going to close this pull request for now, with the possibility of opening it again if someone really really needs this functionality in 0.2.

@weavejester weavejester closed this Apr 9, 2011
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment