run-jetty :configurator set to run last #65

merged 1 commit into from Mar 24, 2012


None yet
2 participants

This change allows for replacing the default proxy-handler with a custom handler; the benefit of this (for us) was to allow for logging custom timing and request information from the handler in a way that provides a general solution without adding new configuration options.

The change simply rearranges what's already happening in the run-jetty function to allow the configurator to have the final say on what the configuration will be; it does not otherwise change the function's behavior.

Includes tests that demonstrate that the configurator can change the handler (and that it is the only handler) and the number of threads in the thread pool. Previously these two operations would be overwritten in run-jetty after the configurator was applied.


weavejester commented Mar 24, 2012

Looks okay. You don't have to open a new pull request if you want to change your commits, though. It's often preferable to keep to one pull request, just so that there's a trail of why decisions were made.

weavejester added a commit that referenced this pull request Mar 24, 2012

Merge pull request #65 from logosity/master
run-jetty :configurator set to run last

@weavejester weavejester merged commit f73c6a8 into mmcgrana:master Mar 24, 2012

Cool, glad it looks good. Yeah, I knew it was lame to do that -- but after I squashed them together, the pull request was showing five commits... wasn't sure if that was what you wanted, and didn't want to keep bouncing this thing around. Since I hadn't used the fork for anything else, thought I'd just start over (still pretty new to using github for more than read-only forking)... Thanks James!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment