Fixes for Issue#54. #66

Closed
wants to merge 5 commits into
from

2 participants

@shanmuha

Fixed the described issues - moved private resource-style function to ring.util.resource for getting resource files as stylesheets.
dump would also return html5 now.
Ring keys updated to added ssl-client-cert as well.

All tests pass and also tested using a dummy ring app using handle-dump.

Shanmu Thiag... added some commits Mar 22, 2012
@weavejester
Collaborator

Thanks for the code. There are a couple of things that need to be fixed, though:

The style-resource function should remain private, even if that means duplicating it in two namespaces. Hiccup is an implementation detail, so Ring should not expose Hiccup-specific functions in its public API.

You also have a bunch of upstream merge commits. You'll need to remove those, I'm afraid, and it might be an idea to squash your remaining commits into one.

Finally, I think we should avoid specifying the content-type as a meta tag, and instead just add the right header to the response (as the stacktrace middleware does).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment