SessionStore and wrap-session documentation #8
2 participants
The return value of delete-session is used as the value of the session cookie. It's usually nil because that removes the cookie. To be honest, I suspect most session stores will want to delete the cookie, but there may be an instance where this option might be useful. It's also consistent with the write-session method, which also returns the cookie value.
The documentation looks fine, but perhaps could do with a few tweaks (such as an explanation of the return value of delete-session). If it's okay, I'll make a few alterations to the patch before applying it.
Regarding the Redis store, don't you have access to alter the wiki? I thought they were publicly editable?
I see, using the return value leaves space for a store that would want to keep a cookie around when the session is deleted. It makes sense...
Sure tweak the patch as much as you need.
I added my redis store to the list of libraries. Thanks
I recently implemented a session store on top of Redis (https://github.com/paraseba/rrss), and I noticed some outdated and incomplete documentation for session store implementers.
My English is not very good, you may want to double check it.
Also, right now we require session stores to return nil on store deletion. I documented this, but I'm not sure it's the correct behavior, I know it's intended, since there is a test case about it. Maybe delete-session should be a no-fail operation, and we should disregard the return value. What do you think about it? I may submit a patch if you want.
By the way, maybe you want to add my redis store library in the "Libraries" section of the wiki.