Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Brushing up the goodness! #2

Open
wants to merge 14 commits into
base: master
from

Conversation

Projects
None yet
2 participants
@lolmaus
Copy link

commented Jun 30, 2016

Thank you for the addon! I should've done it long ago.

This PR contains quite a few changes:

  1. Readme updated to reflect the open source spirit, rather than a personal effort.
  2. url.js is imported via Bower rather than npm/browserify. It lets users avoid importing url.js in the host app, which was a ridiculous requirement. Official url.js repo is used, not a custom build.
  3. Mocha is monkey patched to support "no try/catch" in async tests. Without this patch, the error in console does not have clickable links to specific lines of code.
  4. Styling changes:
    1. Reenabled 50% zoom. This is the default for Ember test setup and thus what most users expect. If you need 100% zoom, please set it up in your host app rather than impose on all addon users.
    2. Resetting HTML background to avoid test report being unreadable for apps with a dark background.
    3. Using transform: translate for sliding the test container instead of right. Makes it smoother.
    4. Using transform: translate also prevents fixed elements from popping out of the test container and covering the report page.
    5. Error message height is reduced to 100px. Resize handle is now available to allow enlarging.
  5. Clicking the page title resets the grep query param and runs all tests.
@mackwic

This comment has been minimized.

Copy link

commented Aug 2, 2016

For those like me that wanted to install the patch:

$ ember install 'https://github.com/lolmaus/ember-cli-mocha-reporter.git#patch-1'
$ bower install 'jillix/url.js#^2.4.0' --save-dev

Thanks for the work, guys. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.