New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

google-plus comments provider #1092

Closed
zmsp opened this Issue Jul 2, 2017 · 3 comments

Comments

Projects
None yet
2 participants
@zmsp
Contributor

zmsp commented Jul 2, 2017

google-plus comments provider seems to be stuck on loading. Didn't really see any javascript error on console.

  • This is a feature request.
  • This is a question about using the theme.
  • I have updated all gems with bundle update.
  • I have tested locally with bundle exec jekyll build.
  • I believe this to be a bug with the theme --- not Jekyll, GitHub Pages or one of the bundled plugins.

Environment informations

Latest minimal-mistakes version
OS: Windows: Chrome/Linux: Firefox

Steps to reproduce the behavior

To reproduce, try to add comments after enabling google-plus commenting.
page: zmsp.github.io/hardware/cryptocurrency/gfx-too-high/
repo: github.com/zmsp/zmsp.github.io
capture

@mmistakes

This comment has been minimized.

Show comment
Hide comment
@mmistakes

mmistakes Jul 3, 2017

Owner

Not sure what's going on. I'm not seeing any script errors. Only thing I can think of Google changed the API or deprecated something.

To get this working originally I followed some instructions from a random blog post. I never could find official documentation from Google on how to embed G+ comments on a website. Wouldn't surprise me at all if they turned this feature off for new posts as they've been scaling back the whole G+ thing the last couple of years.

If you can find some documentation on how to fix or implement it directly from the horse's mouth I'll happily apply it.

Owner

mmistakes commented Jul 3, 2017

Not sure what's going on. I'm not seeing any script errors. Only thing I can think of Google changed the API or deprecated something.

To get this working originally I followed some instructions from a random blog post. I never could find official documentation from Google on how to embed G+ comments on a website. Wouldn't surprise me at all if they turned this feature off for new posts as they've been scaling back the whole G+ thing the last couple of years.

If you can find some documentation on how to fix or implement it directly from the horse's mouth I'll happily apply it.

@zmsp

This comment has been minimized.

Show comment
Hide comment
@zmsp

zmsp Jul 4, 2017

Contributor

This change fixed it. I am not familiar with how it loads the comment box so its not the most elegant. But let me know if you want the change and I can submit a pull request. zmsp/zmsp.github.io@23914d3

changes on _includes/comments.html

<script>
function initComment() {
    gapi.comments.render("g-comments", {
        href: window.location,
        width: "624",
        first_party_property: "BLOGGER",
        view_type: "FILTERED_POSTMOD"
    })
}
</script>
<script async type="text/javascript" src="https://apis.google.com/js/plusone.js" onload="initComment()" />

Pulled from here: https://floaternet.com/gcomments

Contributor

zmsp commented Jul 4, 2017

This change fixed it. I am not familiar with how it loads the comment box so its not the most elegant. But let me know if you want the change and I can submit a pull request. zmsp/zmsp.github.io@23914d3

changes on _includes/comments.html

<script>
function initComment() {
    gapi.comments.render("g-comments", {
        href: window.location,
        width: "624",
        first_party_property: "BLOGGER",
        view_type: "FILTERED_POSTMOD"
    })
}
</script>
<script async type="text/javascript" src="https://apis.google.com/js/plusone.js" onload="initComment()" />

Pulled from here: https://floaternet.com/gcomments

@mmistakes

This comment has been minimized.

Show comment
Hide comment
@mmistakes

mmistakes Jul 4, 2017

Owner

A PR with this fix would be great.

Owner

mmistakes commented Jul 4, 2017

A PR with this fix would be great.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment