New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Social networks disappear after resizing #1136

Closed
diegonc opened this Issue Jul 20, 2017 · 3 comments

Comments

Projects
None yet
4 participants
@diegonc

diegonc commented Jul 20, 2017

  • This is a question about using the theme.
  • This is a feature request.
  • I have updated all gems with bundle update.
  • I have tested locally with bundle exec jekyll build.
  • I believe this to be a bug with the theme --- not Jekyll, GitHub Pages or one of the bundled plugins.

Environment informations

Whatever your site uses. I've tested it at https://mmistakes.github.io/minimal-mistakes/jekyll/gemified-theme-beta/


Expected behavior

I expect the social network links in the author sidebar to be visible after the resize.

Steps to reproduce the behavior

  1. Resize the window until the author sidebar becomes a section before post content. Like, anything below 1024px.
  2. Click the follow button to display the social networks menu
  3. Click the follow button again to hide the menu without choosing a network. This step is important; if you leave the menu open the options will remain visible when proceeding to step 5.
  4. Resize the window back to more than 1024px
  5. Verify that the author sidebar no longer displays the social network links

@mmistakes mmistakes added the Type: Bug label Jul 21, 2017

@juanramirez

This comment has been minimized.

Show comment
Hide comment
@juanramirez

juanramirez Jul 26, 2017

Do you have AdBlock active for the page? It seems that AdBlock doesn't like the class name social-icons. I changed the name of the class to profile-links and they are now shown.

juanramirez commented Jul 26, 2017

Do you have AdBlock active for the page? It seems that AdBlock doesn't like the class name social-icons. I changed the name of the class to profile-links and they are now shown.

@mmistakes

This comment has been minimized.

Show comment
Hide comment
@mmistakes

mmistakes Jul 26, 2017

Owner

@juanramirez Think this is a legit bug. I don't have any AdBlockers installed and @diegonc's steps to reproduce work for me.

What's going on is when the "Follow" button is clicked jQuery is applying inline styles to display: none the author sidebar. Which is fine on mobile, but as soon as you scale the page up it still has display: none and therefore the content inside of it doesn't show.

I'll probably switch the trigger to apply a close class instead of using jQuery's fadeToggle, which gives me more flexibility to style and avoid disappearing content.

I don't think this is a huge bug as the only people likely to be bit by it are developers or those who like to mess with browser window sizes to test for responsiveness. The average user isn't going to view a page on mobile, hit the follow button twice, then magically scale up their screen to a desktop size 😉

Owner

mmistakes commented Jul 26, 2017

@juanramirez Think this is a legit bug. I don't have any AdBlockers installed and @diegonc's steps to reproduce work for me.

What's going on is when the "Follow" button is clicked jQuery is applying inline styles to display: none the author sidebar. Which is fine on mobile, but as soon as you scale the page up it still has display: none and therefore the content inside of it doesn't show.

I'll probably switch the trigger to apply a close class instead of using jQuery's fadeToggle, which gives me more flexibility to style and avoid disappearing content.

I don't think this is a huge bug as the only people likely to be bit by it are developers or those who like to mess with browser window sizes to test for responsiveness. The average user isn't going to view a page on mobile, hit the follow button twice, then magically scale up their screen to a desktop size 😉

@mmistakes mmistakes self-assigned this Aug 4, 2017

@mmistakes mmistakes closed this in 6b9afaa Aug 4, 2017

BoWuGit pushed a commit to BoWuGit/bowugit.github.io that referenced this issue Aug 17, 2017

@JustinTullgren

This comment has been minimized.

Show comment
Hide comment
@JustinTullgren

JustinTullgren Sep 24, 2018

@juanramirez did you push that fix to this repo or just on your fork or personal branch? I am seeing the adblock issue and was hoping master had the fix.

JustinTullgren commented Sep 24, 2018

@juanramirez did you push that fix to this repo or just on your fork or personal branch? I am seeing the adblock issue and was hoping master had the fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment