New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue with minifying plugins #1158

Closed
ashmaroli opened this Issue Aug 6, 2017 · 7 comments

Comments

Projects
None yet
2 participants
@ashmaroli
Contributor

ashmaroli commented Aug 6, 2017

  • This is probably about a bug in the theme.

Environment

  • Minimal Mistakes : v4.4.2 / v4.5.0
  • Jekyll : v3.5.1
  • OS : Windows 7
  • Browser : Google Chrome / Mozilla Firefox
  • Additional Plugins : jekyll-minifier or jekyll-tidy

Expected behavior

Expected no visible change between vanilla site and that generated while using the above plugins.

Actual behavior

Illustrated with screenshots below

Steps to reproduce the behavior

  1. Set up a new project using jekyll 3.5.1
  2. Add a couple of dummy posts
  3. Serve and note render in browser
  4. Install and add either of the following plugins that minify HTML: jekyll-minifier / jekyll-tidy
  5. Restart Jekyll server and note render in browser

Observations

Fresh site setup from jekyll new and some additional dummy posts

mmloc

  • Issue: missing hamburger ?

After enabling a HTML minifying / beautifying plugin:

mmloc2

  • Issue: clobbered viewport
  • Issue: visible hamburger but doesn't respond to my clicks
@mmistakes

This comment has been minimized.

Show comment
Hide comment
@mmistakes

mmistakes Aug 6, 2017

Owner

If I had to guess it's likely screwing with assets/js/main.min.js

I've seen minifiers bork it because of the YAML Front Matter block.

---
layout:
---

Should be easy to verify by diffing the file bundled in the gem against what's in _site/assets/js/

Owner

mmistakes commented Aug 6, 2017

If I had to guess it's likely screwing with assets/js/main.min.js

I've seen minifiers bork it because of the YAML Front Matter block.

---
layout:
---

Should be easy to verify by diffing the file bundled in the gem against what's in _site/assets/js/

@ashmaroli

This comment has been minimized.

Show comment
Hide comment
@ashmaroli

ashmaroli Aug 6, 2017

Contributor

Perfect! I sensed it had something to do with main.js because of the associated console error in the browser. But forgot all about the banner text in the template script. 👍

Removing the banner text in my installed copy of the gem fixes this issue.
Also, the issue that led to the placement of the banner text in the first place has already been fixed in Jekyll 3.5..

So all is good..
N.B.: btw, should the hamburger icon be visible on a laptop? I didn't check the sass files..

Contributor

ashmaroli commented Aug 6, 2017

Perfect! I sensed it had something to do with main.js because of the associated console error in the browser. But forgot all about the banner text in the template script. 👍

Removing the banner text in my installed copy of the gem fixes this issue.
Also, the issue that led to the placement of the banner text in the first place has already been fixed in Jekyll 3.5..

So all is good..
N.B.: btw, should the hamburger icon be visible on a laptop? I didn't check the sass files..

@mmistakes

This comment has been minimized.

Show comment
Hide comment
@mmistakes

mmistakes Aug 6, 2017

Owner

Was thinking the same thing about the banner text. Since 3.5 fixed the issue, adding the blank front matter doesn't need to happen anymore.

The hamburger should only show when the menu items are wider than what can fit on screen. If you had one menu item that is fairly short you could potential never see a hamburger because it fits comfortability in the viewport.

Anything that overflows outside of it gets placed in the hamburger drop down with this script.

Owner

mmistakes commented Aug 6, 2017

Was thinking the same thing about the banner text. Since 3.5 fixed the issue, adding the blank front matter doesn't need to happen anymore.

The hamburger should only show when the menu items are wider than what can fit on screen. If you had one menu item that is fairly short you could potential never see a hamburger because it fits comfortability in the viewport.

Anything that overflows outside of it gets placed in the hamburger drop down with this script.

mmistakes added a commit that referenced this issue Aug 6, 2017

@mmistakes

This comment has been minimized.

Show comment
Hide comment
@mmistakes

mmistakes Aug 6, 2017

Owner

@ashmaroli I removed the blank YAML Front Matter --- --- from assets/js/main.min.js if you want to test out what's on master:

gem "minimal-mistakes-jekyll", :github => "mmistakes/minimal-mistakes"

Let me know if the JS is still getting mangled by those minifier plugins.

Owner

mmistakes commented Aug 6, 2017

@ashmaroli I removed the blank YAML Front Matter --- --- from assets/js/main.min.js if you want to test out what's on master:

gem "minimal-mistakes-jekyll", :github => "mmistakes/minimal-mistakes"

Let me know if the JS is still getting mangled by those minifier plugins.

@ashmaroli

This comment has been minimized.

Show comment
Hide comment
@ashmaroli

ashmaroli Aug 6, 2017

Contributor

This issue has been successfully resolved 👏
😃

Contributor

ashmaroli commented Aug 6, 2017

This issue has been successfully resolved 👏
😃

@ashmaroli ashmaroli closed this Aug 6, 2017

@mmistakes

This comment has been minimized.

Show comment
Hide comment
@mmistakes

mmistakes Aug 6, 2017

Owner

Sweet! Thanks for identifying the issue. Never felt great adding the blank YAML to that file to make it "overridable", glad it could be removed.

Owner

mmistakes commented Aug 6, 2017

Sweet! Thanks for identifying the issue. Never felt great adding the blank YAML to that file to make it "overridable", glad it could be removed.

@ashmaroli

This comment has been minimized.

Show comment
Hide comment
@ashmaroli

ashmaroli Aug 6, 2017

Contributor

My pleasure. 😃

I only did a superficial testing with overriding static asset files. I recommend that you carry out proper tests before releasing the next version to be more than sure it's all proper

Contributor

ashmaroli commented Aug 6, 2017

My pleasure. 😃

I only did a superficial testing with overriding static asset files. I recommend that you carry out proper tests before releasing the next version to be more than sure it's all proper

BoWuGit pushed a commit to BoWuGit/bowugit.github.io that referenced this issue Aug 17, 2017

amweiss added a commit to amweiss/amweiss.github.io that referenced this issue Aug 22, 2017

anouri added a commit to IBMStreams/streamsx.jdbc that referenced this issue Oct 19, 2017

update iopages with common template (#63)
* Bump version to 4.2.0

* Add https prefix to google-universal embed code. (#772)

* Add https prefix to google-universal embed code. (#772)

* Pagination now works for index.html files in subfolders. Links to next page consider baseurl now. (#764)

* Links to next page consider baseurl now.

* paginate_show_page_num controls whether page number gets output.

* Pagination now works for index.html files in subfolders. Links to next page consider baseurl now. (#764)

* Document moving paginated home page to an alternate location

* Update CHANGELOG and history

* Bump version to 4.2.1

* Fix bug - include section for Discourse embedded comments (#825)

* Improve the documentation for novice users (Tags+Categories and Pagination) (#826)

* Enhanced the documentation with some tips for the tags, categories and paginator

* Enhanced the documentation with some tips for the tags, categories and paginator

* Update 05-configuration.md

* Update 10-layouts.md

* Added Korean data in ui-text.yml

Added Korean translations.

* Add long `title` for testing purposes

* Update GreedyNav.js

* Replace with relative sizes

* Update GreedyNav.js

* Update GreedyNav to use flexbox instead of `display: table`
- ref #836

* Run through Autoprefixer

* Add flexbox fixes for < IE9 to make the greedy nav button visible

* Add Russian localized UI text

* Add Russian localized UI text to test and documentation site
- Close #815

* Add Korean localized UI text

* Adjust `author__urls` shadow to match navigation `box-shadow`

* Add Traditional Chinese UI text.

* Add zh-TW UI text to /docs and /test

* Added a few clarifying comments

YAML references are not always obvious, and ensuring people know to remove your Google IDs seemed a good idea to comment on.  Thanks for minimal mistakes!

* meta tag "author" added, for site author the field name is used

* Update README

* Update theme files in /docs

* Add theme meta info to _layouts/default.html

* Add theme meta info

* Update CHANGELOG and history

* Bump version to 4.2.2

* Update theme meta info

* New comment. (#863)

* Escape Liquid

* Escape Liquid

* Change default locale to `en_US` to appease OpenGraph debugger.
- Fixes #843

* Add banner text to main.min.js (#880)

- Add `---` YAML Front Matter as a workaround to allow the theme gem's version to be overridden locally.
- Adjust page scope in Front Matter default to avoid adding a layout to `main.min.js`
- Fixes #874, Fixes #722

* Update CHANGELOG and history

* Bump version to 4.3.0

* Remove buggy conditional around related posts header (#901)

This removes a buggy conditional that checks if `related_label` is
available in translations before displaying the header for related
posts but this header already handle missing translation by using a
default string.

With this fix the header is displayed even if the translation for this
label isn't available.

Fix #900

* Update CHANGELOG

* Bump version to 4.3.1

* Bump version to 4.3.1

* Bump version to 4.3.1

* Removed extra word in comment (#911)

* Typo fix (#915)

* Bump version to 4.3.1

* Update CHANGELOG and history

* Update contributing info

* Update year

* Improve print styles (#919)

* Fix image caption border-radius

* Fix image caption border-radius

* Improve print stylesheet
- Close #909

* Update CHANGELOG and history

* Add Lithuanian language/locale (#924)

* Add Lithuanian language/locale (#924)

* Update CHANGELOG and history

* Replace modified with last_modified_at (#930)

Fixes #929

* Add ProTip about installing unreleased version on `master`

* Update CHANGELOG and history

* Fix `.masthead` and `.page__footer` overlapping full screen video elements.
- Close #933

* Add closing `}`

* Fixed link errors in docs (#946)

* Move SCSS partials to `/_sass/minimal-mistakes` for easier CSS customization

* Release 💎 4.4.0

* Update history

* fix(includes/video): use https always (#945)

closes #944

* Update ui-text.yml (#958)

* Sync `/docs` with root changes

* Update CHANGELOG and history

* New comment. (#967)

* New comment. (#968)

* Add link to comment

* Transition “hamburger” navicon on click to “X” navicon by adding `.close` to button
- Close 969

* Release 💎 4.4.1

* Bump version to 4.4.1

* Toggle close button on `mouseleave`
- Close #975

* Update 08-ui-text.md (#972)

* Update 08-ui-text.md

* Update 08-ui-text.md

* Update CHANGELOG and history to reflect #972

* Add Swedish language (#996)

Translated this for my page today https://github.com/ojn/www.netkom.se/blob/master/_data/ui-text.yml
I hope there are no spelling mistakes, since one should strive for "minimal mistakes"... :-)

* Add Swedish language

* Add new brand variable: $bitbucket-color (#1009)

* Update CHANGELOG and history

* Fix broken Kramdown TOC link

* Fix "Greek" ~> "Swedish" typo

* Removing extraneous a and li tags (#1038)

Removing duplicate <a> and <li> closing tags in paginator include.

* Remove extraneous `</a>` and `</li>` tags

* New comment. (#1064)

* Update comment-1497284119888.yml

* New comment. (#1065)

* Fixed MD link to docs in the 'Helpers' page. (#1066)

* Fix broken link to example _config.yml file (#1069)

* Fix typo

* HTTPS some external links (#1083)

HTTPS some external links

* Google+ page comments updated.

* Fix indentation and remove comments

* Fix indentation and formatting

* Update Google+ page comments for /docs

* Update CHANGELOG and history

* Fixes and updates for the Greek language (#1054)

I have translated some UI text that hadn’t been translated by @Stelios3g. And I have also changed some translated entries to look and sound more natural for general uses (eg ‘Recent posts’ was translated as ‘Latest Announcements’ before). Finally, I have added ‘RSS’ next to ‘Feed’, because 1) there is no translation (or something that sounds natural) in Greek I’m afraid, 2) the term ‘RSS Feed’ is widely used in Greek websites.

* Fixes and updates for the Greek language

* Update CHANGELOG and history

* Add Dutch language (#1081)

* Add mention of Dutch localized UI text strings to theme documentation

* add gitlab to author profile (#1050)

* add gitlab to author profile

* add gitlab to footer

* Fix alignment of :

* Update Update CHANGELOG and history

* Fixed site variables (#1063)

* Fix variable names

* Improve documentation for grid view

* Adjust nav list `.active` state to accommodate text that spans multiple lines.

* Add indonesian locale (#1101)

* Add Indonesian locale text strings

* Update CHANGELOG and history

* Add $navicon-link-color-hover 1/2 (#1089)

Since the orig color-scheme doesn't always represent the nav/site colors

*  Add $navicon-link-color-hover 2/2 (#1088)

Since the orig color-scheme doesn't always represent the nav/site colors

* Add variable for navicon link color

* Replace Gist Liquid tag with embed `script`

* Change `gems` key in config to `plugins`

* Add tzinfo.data gem for Windows to appease timezone error

* Update CHANGELOG and history

* Bump dependencies

* Release 4.4.2

* Bump version to 4.4.2

* Bump version to 4.4.2

* Add vertical scrollbar to sidebars that extend outside the viewport

Viewing overflowing sidebar content requires scrolling the entire page which is annoying and causes the reader to lose their place.

Use CSS `calc` to approximate height of the sidebar (`100vh` - height of the masthead) and apply `overflow-y: auto` to add vertical scrollbars when needed.

Fixes #706

* New comment. (#1116)

* New comment. (#1117)

* New comment. (#1119)

* New comment. (#1120)

* New comment. (#1124)

* New comment. (#1125)

* Use a plugin to read data files from gem

  - jekyll-data v1.x
  - jekyll 3.5 automatically requires a theme's runtime deps
  - jekyll v3.5.0 had bugs. Hence use v3.5.1 and beyond

* New comment. (#1133)

* Upgrade to Susy 3 and replace grid mixins with new `span` and `gutter` functions

Most of Susy's mixins have been deprecated, `@include container()`, `@include full()`, `@include span()`, `@include prefix()`, `@include suffix()`, `@include gallery()`, etc.

Fixes #1114

* Spanish text for comments (#1118)

* Add missing Spanish UI text strings

* Update CHANGELOG

* Add link to PR

* Refactor intro animations into a separate SASS variable (#1147)

* Add `$intro-transition` variable

* Fix space alignment

* Revert `plugins;` back to `gems:` until github/github-pages gem updates to newer Jekyll
- Plugins won't activate if using the new `plugins` key with Jekyll < 3.5

* Update CHANGELOG and history

* Correct name of gem to that of the theme (#1149)

* Include documentation on disabling animations (#1150)

* Update CHANGELOG and history

* Fix typo

* Change reference to "Basically Basic" back to "Minimal Mistakes"

* Update CHANGELOG and history

* Link to PR on GitHub

* Fix disappearing author sidebar links
- Close #1136

* Update CHANGELOG and history

* Header alt tags (#1138)

* Added support for an alt tag for the header image

This allows using page.header.image_description as the alt tag. It
will still default to site.title if unset.

* Added documentation

* DRY up handling of `image_description` for alternative text

* Update CHANGELOG and history

* Update documentation (#1151)

* Update Quickstart documentation

* update Installation documentation

* Update documentation for Overriding Defaults

* Release 💎 4.5.0

* support vietnamese (#1159)

* Add mention of Vietnamese to UI text docs and update CHANGELOG/history

* Remove blank YAML Front Matter from JavaScript banner
- No longer needed ref: jekyll/jekyll#5918

Ref: mmistakes/minimal-mistakes#1158

* Update 05-configuration.md (#1164)

* Update CHANGELOG and history

* Improve `page` and `archive` layouts (#1166)

* Fix collapsed white-space above pagination links

* Improve `page` and `archive` layout
- Center main content on page
- Harmonize sidebar columns to be equal widths

Fixes #1155

* Update CHANGELOG and history

* Position and align right sidebar with the top of the main content

* Offset right sidebar at `$large` viewport

* Add TOC bottom include test post

* Add right sidebar styling edits to documentation site

* Add TOC bottom include test post

* Make minor formatting changes

* Remove outside and right borders in `table`s

* Increase font-size of code blocks.

* Reduce indent of nested "table of contents" links

* Update `website_label`

* Rename gems key to `plugins`
- `gems` key in `_config.yml`  was deprecated in Jekyll 3.5 and changed to `plugins`

ref: jekyll/jekyll#5130

* Reword sentences

* Roll back `gems:` to `plugins:` change in `_config.yml`
- GitHub Pages still doesn't seem to load safe plugins when using `plugins` key

* Fix positioning of sidebar table of contents when using `layout: splash`

Close #1169

* Adjust width of `.sidebar` to match `.sidebar__right`
- Use `$right-sidebar-width-narrow` and `$right-sidebar-width` Sass variables to determine width of sidebar instead of Susy `span` function

* Fix "follow" links `z-index` order to avoid overlapping issues

Close #1167

* Replace `gems` key with `plugins: `

* Extend grid view to the right to better fill the page
- Use a negative right margin to pull `.grid__wrapper` into the dead space left for a sidebar.
- Add sample documents to "portfolio" collection to test grid view
- Update CHANGELOG and history

* Update 16-stylesheets.md (#1170)

Typo error - "want" to "what"

* Update CHANGELOG and history

* Update GEMFILE according description to use theme on github-pages

* First working version

* Remove obsolete files

* remove therubyracer gem

* gem file changed

* delete obsolete files

* synch to original

* *

* Create README.md

* Remove pictures

* remove pictures

* home.md changed excerpt w/o pictures

* Add neutral picture in home page

* Cleaning home page

* Formatting home page

* editme ... first try

* Add editme on the overview pages

* Cleaning

* Cleaning _config.yml

* set x_large variable to 1600

* Update _config.yml editme_path to full url

* Update _includes/editme to support full path from _config.yml

* new include file buttons

* Update _config.yml add github_base_url

* Update home.md add button row

* Change Main navigation from Docu to Documentation

* _config.yml: add page defaults for excerpt, cta_url

* _config.yml add missing slash in spldoc_path

* _config.yml: new defaults are properties of header

      header.cta_url , header.cta_label

* Update _config.yml

* Update home.md

* home.md replace buttons with links

* Update home.md

* Update home.md

* Add possible link in parallel to button

* home.md add link_url and link_label

* Update feature_row

* Update feature_row

* Update feature_row

* Update feature_row

* Switch off the complete Social section in footer.html

* clean gh-pages

* iopages update

* add how to connect pages

ihexon pushed a commit to ihexon/ihexon.github.io that referenced this issue Jul 16, 2018

ihexon pushed a commit to ihexon/ihexon.github.io that referenced this issue Jul 19, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment