New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Items in "You may also enjoy section overlap" $x-large #1213

Closed
UnderNotic opened this Issue Sep 2, 2017 · 2 comments

Comments

Projects
None yet
2 participants
@UnderNotic

UnderNotic commented Sep 2, 2017

I think possible solution would be to increase $x-large breakpoint.
My proposal is to change it from 1280px to 1680px.

capture

@mmistakes

This comment has been minimized.

Show comment
Hide comment
@mmistakes

mmistakes Sep 2, 2017

Owner

I think this is pretty rare... having a string of your length without any spaces. That's what is breaking the layout.

The better option would be to apply some CSS that truncates it with ... for any characters that don't fit in the space.

https://software.intel.com/en-us/html5/hub/blogs/ellipse-my-text/

Owner

mmistakes commented Sep 2, 2017

I think this is pretty rare... having a string of your length without any spaces. That's what is breaking the layout.

The better option would be to apply some CSS that truncates it with ... for any characters that don't fit in the space.

https://software.intel.com/en-us/html5/hub/blogs/ellipse-my-text/

@mmistakes

This comment has been minimized.

Show comment
Hide comment
@mmistakes

mmistakes Sep 6, 2017

Owner

Titles that overflow the parent are now truncated with an ellipsis to avoid breaking the layout.

mm-truncate-overflown-text

Owner

mmistakes commented Sep 6, 2017

Titles that overflow the parent are now truncated with an ellipsis to avoid breaking the layout.

mm-truncate-overflown-text

mmistakes added a commit that referenced this issue Sep 6, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment