New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why do the Author Profile docs suggest modifying _utilities.scss? #1351

Closed
ohadschn opened this Issue Nov 13, 2017 · 3 comments

Comments

Projects
None yet
2 participants
@ohadschn
Contributor

ohadschn commented Nov 13, 2017

https://mmistakes.github.io/minimal-mistakes/docs/layouts/#author-profile

Start by copying _utilities.scss <site root>/_sass. Open it up to the icon section (it’s near the bottom) and nest a new class beneath .social-icons that matches the one used to declare the Font Awesome icon. In our case .fa-reddit.

Isn't it more desirable (simpler and more gem upgrade safe) to edit main.scss? It seems to work...

@mmistakes

This comment has been minimized.

Show comment
Hide comment
@mmistakes

mmistakes Nov 13, 2017

Owner

That bit of documentation was likely written before there was a Ruby gem version.

Best practice when writing Sass is to break up your styles into components, utility classes, mixins, functions, variables, etc. That is the point of view I was taking when I built the themes and documented how and where to update the social icon classes.

So it depends. If you're a repo forker, editing _utilities.scss is the way to go. If you're Ruby gem installer, then dropping in your styles wherever it makes sense to augment the styles is best. The docs could be probably updated to mention both approaches, but that might further complicate things and be too prescriptive.

Owner

mmistakes commented Nov 13, 2017

That bit of documentation was likely written before there was a Ruby gem version.

Best practice when writing Sass is to break up your styles into components, utility classes, mixins, functions, variables, etc. That is the point of view I was taking when I built the themes and documented how and where to update the social icon classes.

So it depends. If you're a repo forker, editing _utilities.scss is the way to go. If you're Ruby gem installer, then dropping in your styles wherever it makes sense to augment the styles is best. The docs could be probably updated to mention both approaches, but that might further complicate things and be too prescriptive.

@mmistakes

This comment has been minimized.

Show comment
Hide comment
@mmistakes

mmistakes Nov 13, 2017

Owner

Note to self: links to _variables.scss and _utitlities.scss are broken and need updating to new paths under /_sass/minimal-mistakes.

Fixed in 423ba0a

Owner

mmistakes commented Nov 13, 2017

Note to self: links to _variables.scss and _utitlities.scss are broken and need updating to new paths under /_sass/minimal-mistakes.

Fixed in 423ba0a

@stale

This comment has been minimized.

Show comment
Hide comment
@stale

stale bot Dec 14, 2017

This issue has been automatically marked as stale because it has not had recent activity.

If this is a bug and you can still reproduce this error on the master branch, please reply with any additional information you have about it in order to keep the issue open.

If this is a feature request, please consider whether it can be accomplished in another way. If it cannot, please elaborate on why it is core to this project and why you feel more than 80% of users would find this beneficial.

This issue will automatically be closed in 7 days if no further activity occurs. Thank you for all your contributions.

stale bot commented Dec 14, 2017

This issue has been automatically marked as stale because it has not had recent activity.

If this is a bug and you can still reproduce this error on the master branch, please reply with any additional information you have about it in order to keep the issue open.

If this is a feature request, please consider whether it can be accomplished in another way. If it cannot, please elaborate on why it is core to this project and why you feel more than 80% of users would find this beneficial.

This issue will automatically be closed in 7 days if no further activity occurs. Thank you for all your contributions.

@stale stale bot added the Status: Stale label Dec 14, 2017

@stale stale bot closed this Dec 21, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment