New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ui-text] zh-HK should be as same as zh-TW #1374

Closed
Covernel opened this Issue Nov 30, 2017 · 2 comments

Comments

Projects
None yet
3 participants
@Covernel

Covernel commented Nov 30, 2017

  • This is a question about using the theme.
  • This is a feature request.
  • I believe this to be a bug with the theme.
    • I have updated all gems with bundle update.
    • I have tested locally with bundle exec jekyll build.

Environment informations

Nil


Expected behavior

zh-HK should be as same as zh-TW

Steps to reproduce the behavior

Nil

Reason

Hong Kong is as same as Taiwan using Traditional Chinese instead of Simplified Chinese

@mmistakes

This comment has been minimized.

Show comment
Hide comment
@mmistakes

mmistakes Dec 4, 2017

Owner

I don't speak any of these languages so I'll just have to take your word for it. Care to submit a pull request with the fix?

Owner

mmistakes commented Dec 4, 2017

I don't speak any of these languages so I'll just have to take your word for it. Care to submit a pull request with the fix?

@fantasticfears

This comment has been minimized.

Show comment
Hide comment
@fantasticfears

fantasticfears Dec 6, 2017

Contributor

I can confirm this because Chinese Wikipedia uses similar approach.

Contributor

fantasticfears commented Dec 6, 2017

I can confirm this because Chinese Wikipedia uses similar approach.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment