New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve masthead, hero overlay, and footer text alignment #342

Closed
mmistakes opened this Issue Jun 6, 2016 · 3 comments

Comments

Projects
None yet
2 participants
@mmistakes
Owner

mmistakes commented Jun 6, 2016

To avoid awkward placement of masthead, overlay text, and footer links, left align all to line up nicely.

mm-left-align

@mmistakes mmistakes self-assigned this Jun 6, 2016

@mmistakes

This comment has been minimized.

Show comment
Hide comment
@mmistakes
Owner

mmistakes commented Jun 7, 2016

@mmistakes mmistakes closed this Jun 7, 2016

@casa-albore

This comment has been minimized.

Show comment
Hide comment
@casa-albore

casa-albore Jul 4, 2016

Much appreciate all this work - but is this change configurable? It completely changes the look of my site (which doesn't use the left-hand side-bar), spoiling it (IMHO). I love the theme though.

casa-albore commented Jul 4, 2016

Much appreciate all this work - but is this change configurable? It completely changes the look of my site (which doesn't use the left-hand side-bar), spoiling it (IMHO). I love the theme though.

@mmistakes

This comment has been minimized.

Show comment
Hide comment
@mmistakes

mmistakes Jul 4, 2016

Owner

@casa-albore If the theme is working out for you no need to update if the change doesn't fit with your site. It's only cosmetic changes in the theme's CSS to better align things since it's meant to be a 2 column theme.

You can easily revert the changes back if you've already merged it in by looking at the commit and adding back the centering.

Changes: ebccf63

Owner

mmistakes commented Jul 4, 2016

@casa-albore If the theme is working out for you no need to update if the change doesn't fit with your site. It's only cosmetic changes in the theme's CSS to better align things since it's meant to be a 2 column theme.

You can easily revert the changes back if you've already merged it in by looking at the commit and adding back the centering.

Changes: ebccf63

cjmadsen pushed a commit to cjmadsen/cjmadsen.github.io that referenced this issue Dec 7, 2016

Merge pull request mmistakes#342 from agusmakmun/master
Update 2016-04-21-stack-problems.markdown
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment