New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No text displayed for 'Next' or 'Previous' for en-GB locale #377

Closed
russellseymour opened this Issue Jun 24, 2016 · 3 comments

Comments

Projects
None yet
2 participants
@russellseymour

russellseymour commented Jun 24, 2016

I have copied the gh-pages branch of the theme as an example to work with.

I have got the following configured in ui-text.yml:

en: &DEFAULT_EN
  page                  : "Page"
  pagination_previous   : "Previous"
  pagination_next       : "Next"
  breadcrumb_home_label : "Home"
  breadcrumb_separator  : "/"

But when I go to one of my _docs pages the Next and Previous is not dispayed:

image

image

I am not sure why may pages are not displaying this. The link works, although there is no text to show that there is a link. I assume I am missing something obvious but I cannot see it.

@mmistakes

This comment has been minimized.

Show comment
Hide comment
@mmistakes

mmistakes Jun 24, 2016

Owner

What have you set your locale as in _config.yml? If it's null or set to something other than en, es, or fr it will be blank (along with most of the other UI text).

<a href="#" class="pagination--pager disabled">{{ site.data.ui-text[site.locale].pagination_previous }}</a>

<a href="#" class="pagination--pager disabled">{{ site.data.ui-text[site.locale].pagination_next }}</a>
Owner

mmistakes commented Jun 24, 2016

What have you set your locale as in _config.yml? If it's null or set to something other than en, es, or fr it will be blank (along with most of the other UI text).

<a href="#" class="pagination--pager disabled">{{ site.data.ui-text[site.locale].pagination_previous }}</a>

<a href="#" class="pagination--pager disabled">{{ site.data.ui-text[site.locale].pagination_next }}</a>
@russellseymour

This comment has been minimized.

Show comment
Hide comment
@russellseymour

russellseymour Jun 27, 2016

@mmistakes Thanks, that solved it :-).

It was set to en-GB which I changed from en-US. I had assumed that it would work, but just setting it to en is OK as is en-US.

russellseymour commented Jun 27, 2016

@mmistakes Thanks, that solved it :-).

It was set to en-GB which I changed from en-US. I had assumed that it would work, but just setting it to en is OK as is en-US.

@mmistakes

This comment has been minimized.

Show comment
Hide comment
@mmistakes

mmistakes Jun 27, 2016

Owner

I think you found a typo. en-GB should have worked but I have it as en-UK in the data file which is clearly wrong.

en-UK:
  <<: *DEFAULT_EN

Should be

en-GB:
  <<: *DEFAULT_EN
Owner

mmistakes commented Jun 27, 2016

I think you found a typo. en-GB should have worked but I have it as en-UK in the data file which is clearly wrong.

en-UK:
  <<: *DEFAULT_EN

Should be

en-GB:
  <<: *DEFAULT_EN

@mmistakes mmistakes reopened this Jun 27, 2016

@mmistakes mmistakes changed the title from No text displayed for 'Next' or 'Previous' to No text displayed for 'Next' or 'Previous' for `en-GB` locale Jun 27, 2016

@mmistakes mmistakes changed the title from No text displayed for 'Next' or 'Previous' for `en-GB` locale to No text displayed for 'Next' or 'Previous' for en-GB locale Jun 27, 2016

@mmistakes mmistakes closed this in e536f04 Jul 1, 2016

sobkowiak added a commit to sobkowiak/sobkowiak.github.io-new that referenced this issue Jul 18, 2016

sobkowiak added a commit to sobkowiak/sobkowiak.github.io-new that referenced this issue Jul 18, 2016

cjmadsen pushed a commit to cjmadsen/cjmadsen.github.io that referenced this issue Dec 7, 2016

jluccisano added a commit to jluccisano/jluccisano.github.io that referenced this issue May 6, 2017

antonizoon pushed a commit to antonizoon/antonizoon.github.io that referenced this issue Jul 27, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment