New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limitation in the no of images in gallery #402

Closed
adrianbradu opened this Issue Jul 20, 2016 · 2 comments

Comments

Projects
None yet
2 participants
@adrianbradu

adrianbradu commented Jul 20, 2016

I like the gallery helper; However it looks like it is properly working with a maximum 9 of images in the gallery. So far the solution for this is to greate gallery1 and gallery2 in the YAML Front Matter then:

{%include gallery id="gallery1"%}
{%include gallery id="gallery2"%}

Is there any way to sort out this?
Thanks a lot

@mmistakes

This comment has been minimized.

Show comment
Hide comment
@mmistakes

mmistakes Jul 20, 2016

Owner

Do you have an example of a gallery with > 9 images that isn't working? To my knowledge there's nothing in the gallery include's Liquid that is enforcing any sort of maximum amount of images.

Owner

mmistakes commented Jul 20, 2016

Do you have an example of a gallery with > 9 images that isn't working? To my knowledge there's nothing in the gallery include's Liquid that is enforcing any sort of maximum amount of images.

@mmistakes

This comment has been minimized.

Show comment
Hide comment
@mmistakes

mmistakes Jul 20, 2016

Owner

Looking at this closer appears there's a bug with some of my Liquid. Stay tuned for a fix...

Update: fixed, see commit below. Updated sample gallery page (.md source) as reference.

Owner

mmistakes commented Jul 20, 2016

Looking at this closer appears there's a bug with some of my Liquid. Stay tuned for a fix...

Update: fixed, see commit below. Updated sample gallery page (.md source) as reference.

@mmistakes mmistakes closed this in 2d818cc Jul 20, 2016

mmistakes added a commit that referenced this issue Jul 20, 2016

Fix gallery size bug
-  Improperly evaluated size of gallery arrays as strings and not integers
- Close #402

cjmadsen pushed a commit to cjmadsen/cjmadsen.github.io that referenced this issue Dec 7, 2016

jluccisano added a commit to jluccisano/jluccisano.github.io that referenced this issue May 6, 2017

Fix gallery size bug
-  Improperly evaluated size of gallery arrays as strings and not integers
- Close mmistakes#402

antonizoon pushed a commit to antonizoon/antonizoon.github.io that referenced this issue Jul 27, 2018

Fix gallery size bug
-  Improperly evaluated size of gallery arrays as strings and not integers
- Close mmistakes#402
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment