New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Underscores & Hyphens in the og:locale meta tag #462

Closed
carpiediem opened this Issue Aug 18, 2016 · 1 comment

Comments

Projects
None yet
2 participants
@carpiediem
Contributor

carpiediem commented Aug 18, 2016

  • This is a question about using the theme.
  • I believe this to be a bug with the theme --- not Jekyll, GitHub Pages or one of the bundled plugins.
  • This is a feature request.
  • [x ] I have updated all gems with bundle update.
  • I have tested locally with bundle exec jekyll build.

Environment informations

Running on github.io


Expected behavior

og:locale meta tag should be processed

Steps to reproduce the behavior

If you test a page in https://developers.facebook.com/tools/debug/sharing/, it shows that the og:locale tag is being rejected. Facebook is expecting a value with an underscore (e.g. "en_US") but the default configuration of minimal-mistakes uses a hyphen (e.g. "en-US").

Simply modifying the _config.yml file isn't an option, since ui-text.yml is written for hyphens. I think those are the only two files that would need to be edited, though.

@mmistakes

This comment has been minimized.

Show comment
Hide comment
@mmistakes

mmistakes Aug 18, 2016

Owner

Should be an easy fix adding a replace filter and changing the default to en_US to this line in _includes/seo.html

<meta property="og:locale" content="{{ site.locale | replace: "-", "_" | default: "en_US" }}">
Owner

mmistakes commented Aug 18, 2016

Should be an easy fix adding a replace filter and changing the default to en_US to this line in _includes/seo.html

<meta property="og:locale" content="{{ site.locale | replace: "-", "_" | default: "en_US" }}">
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment