New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ID of staticman comments section not sufficiently unique #582

Closed
lunaryorn opened this Issue Oct 10, 2016 · 2 comments

Comments

Projects
None yet
2 participants
@lunaryorn
Copy link
Contributor

lunaryorn commented Oct 10, 2016

The staticman comments section has the ID #comments which isn't really unique, given that kramdown automatically generates IDs from headlines. Specifically, any "Comments" headline would also generate the ID #comments.

I hit this when I added staticman to my blog which has an article about syntax highlighting which talks about source code comments in a section named, well, "Comments".

I solved the issue for my blog by prefixing the IDs generated by Kramdown, but I think the ID of the comments should be more unique nonetheless, e.g. minimal-mistakes-staticman-comments or so… just something that's less likely to conflict with a header ID.

@mmistakes

This comment has been minimized.

Copy link
Owner

mmistakes commented Oct 10, 2016

Good catch. I'll have to double check by pretty sure I'm not using #comments anywhere so it could easily be removed from the <section> element.

@mmistakes mmistakes added this to the 4.0 milestone Oct 10, 2016

@mmistakes mmistakes self-assigned this Oct 10, 2016

@mmistakes

This comment has been minimized.

Copy link
Owner

mmistakes commented Nov 17, 2016

Fixed in 3a7dd49 and will be in the next release of MM

@mmistakes mmistakes closed this in 3a7dd49 Nov 17, 2016

TheCodedSelf pushed a commit to TheCodedSelf/thecodedself.github.io that referenced this issue Dec 7, 2016

jluccisano added a commit to jluccisano/jluccisano.github.io that referenced this issue May 6, 2017

antonizoon pushed a commit to antonizoon/antonizoon.github.io that referenced this issue Jul 27, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment