New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Read time not displayed for posts #657

Closed
ashleyconnor opened this Issue Nov 18, 2016 · 4 comments

Comments

Projects
None yet
2 participants
@ashleyconnor

ashleyconnor commented Nov 18, 2016

  • I believe this to be a bug with the theme --- not Jekyll, GitHub Pages or one of the bundled plugins.
  • I have updated all gems with bundle update.
  • I have tested locally with bundle exec jekyll build.

Environment informations

  • Minimal Mistakes version: minimal-mistakes-jekyll (4.0.7)
  • github-pages or jekyll gem version: jekyll 3.3.1
  • Operating system: OSX/S3

Expected behavior

Read time to be displayed for each blog post

Steps to reproduce the behavior

https://github.com/ashleyconnor/blog
ashleyconnor.co.uk

Below you can see the fa-clock but no time.

https://www.dropbox.com/s/5sj1q3cb2vyee7g/Screenshot%202016-11-18%2008.30.32.png?dl=1

@mmistakes

This comment has been minimized.

Show comment
Hide comment
@mmistakes

mmistakes Nov 18, 2016

Owner

You're missing one small config line. Add words_per_minute: 200 to your _config.yml and it should work.

Owner

mmistakes commented Nov 18, 2016

You're missing one small config line. Add words_per_minute: 200 to your _config.yml and it should work.

@ashleyconnor

This comment has been minimized.

Show comment
Hide comment
@ashleyconnor

ashleyconnor Nov 18, 2016

I'll try that tonight. The docs make it sound like there's a default of 200 already and I only need to add the config entry to override that value.

Reading Time

Enable estimated reading time snippets with read_time: true in YAML Front Matter. 200 has been set as the default words per minute value — which can be changed by adjusting words_per_minutes: in _config.yml.

I guess the keyword here is adjusting - which would imply it was set. My bad.

ashleyconnor commented Nov 18, 2016

I'll try that tonight. The docs make it sound like there's a default of 200 already and I only need to add the config entry to override that value.

Reading Time

Enable estimated reading time snippets with read_time: true in YAML Front Matter. 200 has been set as the default words per minute value — which can be changed by adjusting words_per_minutes: in _config.yml.

I guess the keyword here is adjusting - which would imply it was set. My bad.

@mmistakes

This comment has been minimized.

Show comment
Hide comment
@mmistakes

mmistakes Nov 18, 2016

Owner

Going to make a fix to _includes/read-time.html that properly sets words_per_minute if it's omitted from the config file.

The new theme gem way of installing doesn't include it. So the fix for now is adding to your config. That and you'll probably want to add locale: en as well since I noticed that missing.

Owner

mmistakes commented Nov 18, 2016

Going to make a fix to _includes/read-time.html that properly sets words_per_minute if it's omitted from the config file.

The new theme gem way of installing doesn't include it. So the fix for now is adding to your config. That and you'll probably want to add locale: en as well since I noticed that missing.

@mmistakes mmistakes added the Type: Bug label Nov 18, 2016

@mmistakes mmistakes self-assigned this Nov 18, 2016

@mmistakes

This comment has been minimized.

Show comment
Hide comment
@mmistakes

mmistakes Nov 18, 2016

Owner

Fixed in f9e3676

Owner

mmistakes commented Nov 18, 2016

Fixed in f9e3676

@mmistakes mmistakes closed this in f9e3676 Nov 21, 2016

TheCodedSelf pushed a commit to TheCodedSelf/thecodedself.github.io that referenced this issue Dec 7, 2016

@ashleyconnor ashleyconnor changed the title from Read time no displayed for posts to Read time not displayed for posts Mar 7, 2017

jluccisano added a commit to jluccisano/jluccisano.github.io that referenced this issue May 6, 2017

antonizoon pushed a commit to antonizoon/antonizoon.github.io that referenced this issue Jul 27, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment