New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dynamic `words_per_minute` "less than" and "minute read" values #703

Closed
iamsk opened this Issue Dec 8, 2016 · 3 comments

Comments

Projects
None yet
2 participants
@iamsk
Copy link

iamsk commented Dec 8, 2016

branch: master

It's better make 180 and 360 related to words_per_minute setting.
Different type of article have different reading speed as your design.

Thanks for your creating this amazing theme.

@mmistakes

This comment has been minimized.

Copy link
Owner

mmistakes commented Dec 12, 2016

word_per_minute is configurable.

Feel free to change it to a different value in your _config.yml if the 200 default doesn't work for you.

@mmistakes mmistakes closed this Dec 12, 2016

@iamsk

This comment has been minimized.

Copy link

iamsk commented Dec 13, 2016

What I mean is this part:
{% if words < 180 %} {{ site.data.ui-text[site.locale].less_than | default: "less than" }} 1 {{ site.data.ui-text[site.locale].minute_read | default: "minute read" }} {% elsif words < 360 %} 1 {{ site.data.ui-text[site.locale].minute_read | default: "minute read" }}

@mmistakes

This comment has been minimized.

Copy link
Owner

mmistakes commented Dec 13, 2016

Gotcha.

@mmistakes mmistakes reopened this Dec 13, 2016

@mmistakes mmistakes changed the title words_per_minute not work if words less than 360 Dynamic `words_per_minute` "less than" and "minute read" values Dec 13, 2016

@mmistakes mmistakes closed this in 1cfce57 Dec 22, 2016

jluccisano added a commit to jluccisano/jluccisano.github.io that referenced this issue May 6, 2017

martinbjeldbak added a commit to martinbjeldbak/martinbjeldbak.github.io that referenced this issue Feb 1, 2018

Merge remote-tracking branch 'upstream/master'
* upstream/master:
  New comment. (mmistakes#751)
  New comment. (mmistakes#750)
  Fix typo
  New comment. (mmistakes#745)
  New comment. (mmistakes#743)
  New comment. (mmistakes#729)
  Bump version to 4.1.1
  Update CHANGELOG.md and history
  Remove hardcoded read time values and make “minute read” values dynamic based off of `site.words_per_minute` - Close mmistakes#703
  Fix `author.youtube` conditional in author sidebar
  Change Jekyll to a runtime dependency
  Add support for YouTube channel URLs in `/docs` author sidebar
  Add support for YouTube channel URLs in author sidebar - Close mmistakes#716
  Update Font Awesome to v4.7.0 in `/docs`
  Update Font Awesome to v4.7.0 - Close mmistakes#723
  Bump version to 4.1.0
  Update CHANGELOG and history
  Add include for adding custom author profile links to sidebar
  Fix padding issue with pagination buttons - Close mmistakes#694
  Fix link to Discourse.org homepage in noscript section (mmistakes#699)

antonizoon pushed a commit to antonizoon/antonizoon.github.io that referenced this issue Jul 27, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment