New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sidebar: Not able to see overflow content in sidebar until scroll down till the end of the page. #706

Closed
vanlong441 opened this Issue Dec 8, 2016 · 7 comments

Comments

Projects
None yet
3 participants
@vanlong441

vanlong441 commented Dec 8, 2016

http://i.imgur.com/RUfHq1w.png --> Scroll down to half a page
http://i.imgur.com/u270pcc.png --> Scroll down to the bottom of the page

@mmistakes

This comment has been minimized.

Show comment
Hide comment
@mmistakes

mmistakes Dec 8, 2016

Owner

Unfortunately there is no way around this without introducing a scrollbar or something similar on the sidebar.

Your only option is to disable the "sticky" sidebar and then it will scroll with the rest of the page content. If you want to go with that solution remove the sticky class from the sidebar.

Owner

mmistakes commented Dec 8, 2016

Unfortunately there is no way around this without introducing a scrollbar or something similar on the sidebar.

Your only option is to disable the "sticky" sidebar and then it will scroll with the rest of the page content. If you want to go with that solution remove the sticky class from the sidebar.

@vanlong441

This comment has been minimized.

Show comment
Hide comment
@vanlong441

vanlong441 Dec 9, 2016

@mmistakes I suggest that the y-scrollbar become visible when mouseover with x-scrollbar always hidden...

vanlong441 commented Dec 9, 2016

@mmistakes I suggest that the y-scrollbar become visible when mouseover with x-scrollbar always hidden...

@mmistakes

This comment has been minimized.

Show comment
Hide comment
@mmistakes

mmistakes Dec 9, 2016

Owner

Happy to look at a pull request if you want to submit a fix.

Owner

mmistakes commented Dec 9, 2016

Happy to look at a pull request if you want to submit a fix.

@mmistakes

This comment has been minimized.

Show comment
Hide comment
@mmistakes

mmistakes Jul 12, 2017

Owner

Added support for sidebar scrollbars when needed in 3e34797

Owner

mmistakes commented Jul 12, 2017

Added support for sidebar scrollbars when needed in 3e34797

@rashevskyv

This comment has been minimized.

Show comment
Hide comment
@rashevskyv

rashevskyv Jul 23, 2017

With sticky class on in mobile view content moves under the screen

http://prntscr.com/fzak4u - w\o sticky
http://prntscr.com/fzakyz - w sticky

rashevskyv commented Jul 23, 2017

With sticky class on in mobile view content moves under the screen

http://prntscr.com/fzak4u - w\o sticky
http://prntscr.com/fzakyz - w sticky

@mmistakes

This comment has been minimized.

Show comment
Hide comment
@mmistakes

mmistakes Jul 23, 2017

Owner

@rashevskyv The theme purposely doesn't apply position: sticky to those elements on < 1024 pixel wide screens for this very reason.

Are you using a modified version of the theme? You'll probably need some JavaScript to make it work.

Owner

mmistakes commented Jul 23, 2017

@rashevskyv The theme purposely doesn't apply position: sticky to those elements on < 1024 pixel wide screens for this very reason.

Are you using a modified version of the theme? You'll probably need some JavaScript to make it work.

@rashevskyv

This comment has been minimized.

Show comment
Hide comment
@rashevskyv

rashevskyv Jul 24, 2017

Yes, it is modified, but only in some variables. On clean mm it works fine?
btw, page has alot of menu -
image

rashevskyv commented Jul 24, 2017

Yes, it is modified, but only in some variables. On clean mm it works fine?
btw, page has alot of menu -
image

BoWuGit pushed a commit to BoWuGit/bowugit.github.io that referenced this issue Aug 17, 2017

Add vertical scrollbar to sidebars that extend outside the viewport
Viewing overflowing sidebar content requires scrolling the entire page which is annoying and causes the reader to lose their place.

Use CSS `calc` to approximate height of the sidebar (`100vh` - height of the masthead) and apply `overflow-y: auto` to add vertical scrollbars when needed.

Fixes mmistakes#706
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment