Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
`position: sticky` causes sidebar overlap in Chrome #752
Hi, thanks for minimal-mistakes! I just deployed it yesterday on kvz.io and loving it so far. One person on reddit reported it looked weird - but it looks fine in my browsers.
The page in question is http://kvz.io/blog/2017/01/04/introducing-lanyon/ - Beyond social buttons, i did not make any layout changes, only config & markdown.
For convenience here is a direct screenshot for Chrome 56 on windows: http://i.imgur.com/BxfzHrn.png
Does the overlap happen on all pages that have the author sidebar? or just that one?
Other than that I'm at a loss as to what's going on.
Tested on beta Chrome 56 on Windows and all works as it should.
Still not sure why it's broken for that redditor, could be something JS related. I know there's stuff in the theme that was added awhile back that tests the width of things to trigger the sticky polyfill, and that could be borked for whatever reason.
I do what I can
In the end I took out the polyfill. In Firefox, Safari, and Chrome 56 the sidebar will "stick" as it should. On older browsers it scrolls with the rest of the page, which isn't so bad either.
If you're interested in making the changing it's pretty small and in this commit. I'll roll it out officially in the next release.
@NathanHeffley Definitely not the case. It may be hard to tell from the GIF but the screen was much wider than 100px.
Tested on both Windows and Mac Chrome 56 (beta) and couldn't reproduce the overlap.
Curious to know if you have any plugins installed that might mess with JS or noticed any script errors in the console.