New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add conditional comment to http-equiv="cleartype" meta tag #1087

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
2 participants
@justinrummel
Contributor

justinrummel commented Jun 28, 2017

Conditional comment as this is a fix for IE Mobile devices. By doing this resolves validation errors.

Same as: h5bp/mobile-boilerplate@feb59c5

Update head.html
Conditional comment as this is a fix for IE Mobile devices.  By doing this resolves validation errors.  

Same as: h5bp/mobile-boilerplate@feb59c5
@mmistakes

This comment has been minimized.

Show comment
Hide comment
@mmistakes

mmistakes Jun 28, 2017

Owner

Do you know if this affects desktop browsers that could benefit from turning on cleartype? And if the line even needs to be there anymore? Looking at that commit from the mobile H5BP, that project was deprecated years ago.

And in the main H5BP they don't use the cleartype meta line at all.

Owner

mmistakes commented Jun 28, 2017

Do you know if this affects desktop browsers that could benefit from turning on cleartype? And if the line even needs to be there anymore? Looking at that commit from the mobile H5BP, that project was deprecated years ago.

And in the main H5BP they don't use the cleartype meta line at all.

@justinrummel

This comment has been minimized.

Show comment
Hide comment
@justinrummel

justinrummel Jun 28, 2017

Contributor

Unfortunately I'm not a knowledgeable resource on this item. I was running my site through some validators (Rocket Validator specifically) and this item surfaced. I thought the general site could use this update vs. creating a local _includes/head.html gem override. I did question if the right course of action would to remove the line entirely... but again I'm not sure.

I don't know if this effects all other browsers... I've only tested on Desktop and Mobile Safari, everything looks fine.

Contributor

justinrummel commented Jun 28, 2017

Unfortunately I'm not a knowledgeable resource on this item. I was running my site through some validators (Rocket Validator specifically) and this item surfaced. I thought the general site could use this update vs. creating a local _includes/head.html gem override. I did question if the right course of action would to remove the line entirely... but again I'm not sure.

I don't know if this effects all other browsers... I've only tested on Desktop and Mobile Safari, everything looks fine.

@mmistakes

This comment has been minimized.

Show comment
Hide comment
@mmistakes

mmistakes Jun 28, 2017

Owner
Owner

mmistakes commented Jun 28, 2017

@mmistakes mmistakes closed this in eb1f445 Aug 29, 2017

@mmistakes mmistakes changed the title from Update head.html to Add conditional comment to http-equiv="cleartype" meta tag Aug 29, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment