New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add $navicon-link-color-hover 1/2 #1089

Merged
merged 1 commit into from Jul 7, 2017

Conversation

Projects
None yet
2 participants
@palatinux
Contributor

palatinux commented Jun 29, 2017

Since the orig color-scheme doesn't always represent the nav/site colors

Add $navicon-link-color-hover 1/2
Since the orig color-scheme doesn't always represent the nav/site colors
@palatinux

This comment has been minimized.

Show comment
Hide comment
@palatinux

palatinux Jul 6, 2017

Contributor

You can compare now with https://github.com/palatinux/minimal-mistakes/ Don't know how to push multiple commits into one push

Contributor

palatinux commented Jul 6, 2017

You can compare now with https://github.com/palatinux/minimal-mistakes/ Don't know how to push multiple commits into one push

@mmistakes

This comment has been minimized.

Show comment
Hide comment
@mmistakes

mmistakes Jul 6, 2017

Owner

The easiest way is to fork, create a new branch from master, add your commits, push that branch up, then submit a PR.

You can also keep pushing commits to this branch, though looking up above looks like you might have deleted the source branch.

It's a cleaner merge if it's all in one PR, something this small doesn't need to be broken up into multiple PRs.

Owner

mmistakes commented Jul 6, 2017

The easiest way is to fork, create a new branch from master, add your commits, push that branch up, then submit a PR.

You can also keep pushing commits to this branch, though looking up above looks like you might have deleted the source branch.

It's a cleaner merge if it's all in one PR, something this small doesn't need to be broken up into multiple PRs.

@mmistakes mmistakes merged commit 951b2c7 into mmistakes:master Jul 7, 2017

BoWuGit pushed a commit to BoWuGit/bowugit.github.io that referenced this pull request Aug 17, 2017

Add $navicon-link-color-hover 1/2 (mmistakes#1089)
Since the orig color-scheme doesn't always represent the nav/site colors
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment