New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

URL Encode Title and Page URL in Social Share Links #1177

Merged
merged 1 commit into from Aug 18, 2017

Conversation

Projects
None yet
2 participants
@rjkaes

rjkaes commented Aug 15, 2017

The links to the various social networks include data from the post
(title and url) which can contain URL special characters. Pass each of
the generated URLs through Liquid's url_encode filter to build HTML
complaint URLs.

Robert James Kaes
URL Encode Title and Page URL in Social Share Links
The links to the various social networks include data from the post
(title and url) which can contain URL special characters.  Pass each of
the generated URLs through Liquid's `url_encode` filter to build HTML
complaint URLs.

@mmistakes mmistakes merged commit 10bc756 into mmistakes:master Aug 18, 2017

@mmistakes

This comment has been minimized.

Show comment
Hide comment
@mmistakes
Owner

mmistakes commented Aug 18, 2017

Thanks @rjkaes

@rjkaes rjkaes deleted the rjkaes:escape-url-in-social-share branch Aug 18, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment